Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intl: fix limit calculation #41026

Merged
merged 1 commit into from Dec 10, 2021
Merged

Commits on Nov 29, 2021

  1. src: fix limit calculation

    Coverity reported that the use of sizeof along with pointer
    arithmetic was likely an error as the pointer arithmetic
    would already be accounting for the size of what the
    pointer points to.
    
    Looking at the code that looked right but removing the
    extra sizeOf caused tests to fail.
    
    Looking more closely it seems like we were not allocating
    a big enough buffer but the extra sizeof was allowing
    us to convert even though it might have been corrupting
    memory.
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    mhdawson committed Nov 29, 2021
    Copy the full SHA
    54f24fb View commit details
    Browse the repository at this point in the history