Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: enable JSDoc check-alignment lint rule #41109

Merged
merged 2 commits into from Dec 9, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion .eslintrc.js
Expand Up @@ -352,7 +352,6 @@ module.exports = {
'jsdoc/check-param-names': 'off',
'jsdoc/tag-lines': 'off',
'jsdoc/require-returns-type': 'off',
'jsdoc/check-alignment': 'off',

// Custom rules from eslint-plugin-node-core
'node-core/no-unescaped-regexp-dot': 'error',
Expand Down
2 changes: 1 addition & 1 deletion doc/api/tls.md
Expand Up @@ -1010,7 +1010,7 @@ const keyingMaterial = tlsSocket.exportKeyingMaterial(
128,
'client finished');

/**
/*
Example return value of keyingMaterial:
<Buffer 76 26 af 99 c5 56 8e 42 09 91 ef 9f 93 cb ad 6c 7b 65 f8 53 f1 d8 d9
12 5a 33 b8 b5 25 df 7b 37 9f e0 e2 4f b8 67 83 a3 2f cd 5d 41 42 4c 91
Expand Down
4 changes: 2 additions & 2 deletions doc/api/url.md
Expand Up @@ -1235,7 +1235,7 @@ import { urlToHttpOptions } from 'url';
const myURL = new URL('https://a:b@測試?abc#foo');

console.log(urlToHttpOptions(myURL));
/**
/*
{
protocol: 'https:',
hostname: 'xn--g6w251d',
Expand All @@ -1254,7 +1254,7 @@ const { urlToHttpOptions } = require('url');
const myURL = new URL('https://a:b@測試?abc#foo');

console.log(urlToHttpOptions(myUrl));
/**
/*
{
protocol: 'https:',
hostname: 'xn--g6w251d',
Expand Down
2 changes: 1 addition & 1 deletion lib/internal/bootstrap/loaders.js
Expand Up @@ -192,7 +192,7 @@ class NativeModule {
/**
* A map from the module IDs to the module instances.
* @type {Map<string, NativeModule>}
*/
*/
static map = new SafeMap(
ArrayPrototypeMap(moduleIds, (id) => [id, new NativeModule(id)])
);
Expand Down
6 changes: 3 additions & 3 deletions tools/eslint-rules/rules-utils.js
Expand Up @@ -30,9 +30,9 @@ module.exports.isRequired = function(node, modules) {
};

/**
* Return true if common module is required
* in AST Node under inspection
*/
* Return true if common module is required
* in AST Node under inspection
*/
const commonModuleRegExp = new RegExp(/^(\.\.\/)*common(\.js)?$/);
module.exports.isCommonModule = function(node) {
return isRequireCall(node) &&
Expand Down