[v12.x] build: pin macOS GitHub runner to macos-10.15 #41124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
meta
lpinca
approved these changes
Dec 9, 2021
|
This does not affect node/.github/workflows/test-macos.yml Line 21 in 1f48dd8 |
BethGriggs
approved these changes
Dec 9, 2021
targos
approved these changes
Dec 10, 2021
Node.js 12.x requires Python 2 to build. `macos-latest` GitHub hosted runners are now macOS 11 and do not have Python 2 available. PR-URL: nodejs#41124 Refs: actions/runner-images#4060 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau
force-pushed
the
v12.x-staging-macos-runner
branch
from
208c62c
to
2d42295
Compare
|
Landed in 2d42295. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js 12.x requires Python 2 to build.
macos-latestGitHubhosted runners are now macOS 11 and do not have Python 2 available.
Refs: actions/runner-images#4060
Node.js 12 is in maintenance and goes End-of-Life next April (2022). This pull request is to attempt to fix the GitHub actions macOS workflow by pinning the runner to the macOS version we were previously testing on before GitHub updated what
macos-latestpoints to,Example of failing run on b13340e (current
v12.x-staging: https://github.com/nodejs/node/actions/runs/1559350131If this doesn't work I'd propose dropping this workflow from
v12.x-- I briefly looked at the Python 3 PRs that landed in the later release lines and I would not be comfortable attempting to backport those tov12.xthis late in its lifecycle.