Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: add jsdoc details for Event and EventTarget #41274

Closed
wants to merge 2 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Dec 21, 2021

Signed-off-by: James M Snell jasnell@gmail.com

Signed-off-by: James M Snell <jasnell@gmail.com>
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Dec 21, 2021
@aduh95 aduh95 added the typings label Dec 21, 2021
lib/internal/event_target.js Outdated Show resolved Hide resolved
Co-authored-by: Rich Trott <rtrott@gmail.com>
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Dec 21, 2021
jasnell added a commit that referenced this pull request Dec 24, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #41274
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Dec 24, 2021

Landed in 9d6bd10

@jasnell jasnell closed this Dec 24, 2021
targos pushed a commit that referenced this pull request Jan 14, 2022
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #41274
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #41274
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#41274
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #41274
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. typings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants