Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: additional guidance about amending commits #41287

Merged
merged 6 commits into from Dec 26, 2021
Merged

doc: additional guidance about amending commits #41287

merged 6 commits into from Dec 26, 2021

Commits on Dec 22, 2021

  1. doc: additional guidance about amending commits 

    In my first contribution, I got the amending guidance
wrongly and amended my commit to attend some requested
changes. So I added some more lines in the docs to help the
further contributors to don't make the same mistake that I did
    @Farenheith
    Farenheith committed Dec 22, 2021
    Copy the full SHA
    5e8f611 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2021

  1. doc: removing commit --amend recommendation

    @Farenheith
    Farenheith committed Dec 23, 2021
    Copy the full SHA
    758e7ab View commit details
    Browse the repository at this point in the history

  2. doc: adding more insight about force pushing

    @Farenheith
    Farenheith committed Dec 23, 2021
    Copy the full SHA
    712175f View commit details
    Browse the repository at this point in the history

  3. Update doc/guides/contributing/pull-requests.md 

    Making all drawbacks to be listed in a row

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @Farenheith @aduh95
    Farenheith and aduh95 committed Dec 23, 2021
    Copy the full SHA
    5695a24 View commit details
    Browse the repository at this point in the history

  4. doc: putting the new tips before 'Before you use it' 

    This way all the drawbacks are in a row
    @Farenheith
    Farenheith committed Dec 23, 2021
    Copy the full SHA
    3559e44 View commit details
    Browse the repository at this point in the history

  5. Update doc/guides/contributing/pull-requests.md 

    Fixing duplicated additional guidance about for pushing

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @Farenheith @aduh95
    Farenheith and aduh95 committed Dec 23, 2021
    Copy the full SHA
    98d15ba View commit details
    Browse the repository at this point in the history