Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove duplicate test about warning in lib/net.js #41307

Merged
merged 4 commits into from Dec 27, 2021
Merged

test: remove duplicate test about warning in lib/net.js #41307

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7fa3e4e
test: remove duplicate test about deprecation warning
kuriyosh Dec 24, 2021
c23d0e6
test: revert two test and add comments for each
kuriyosh Dec 26, 2021
2045739
test: fix lint error
kuriyosh Dec 26, 2021
6ef49ff
test: update comment for test description
kuriyosh Dec 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions test/parallel/test-net-deprecated-setsimultaneousaccepts.js
View file
Open in desktop
@@ -1,6 +1,9 @@
// Flags: --no-warnings
'use strict';

// This test checks that `_setSimultaneousAccepts` emit DEP0121 warning.
// Ref test-net-server-simultaneous-accepts-produce-warning-once.js
Copy link
Member

@Trott Trott Dec 26, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// This test checks that `_setSimultaneousAccepts` emit DEP0121 warning.
// Ref test-net-server-simultaneous-accepts-produce-warning-once.js
// Test that DEP0121 is emitted on the first call of _setSimultaneousAccepts().


const {
expectWarning
} = require('../common');
Expand Down
10 changes: 7 additions & 3 deletions test/parallel/test-net-server-simultaneous-accepts-produce-warning-once.js
View file
Open in desktop
@@ -1,12 +1,16 @@
'use strict';

// This test checks that `_setSimultaneousAccepts` does not emit DEP0121 warning
// in second calling, by combination with
// `test-net-deprecated-setsimultaneousaccepts.js`.
kuriyosh marked this conversation as resolved.
Show resolved Hide resolved

const { expectWarning } = require('../common');
const net = require('net');
const { _setSimultaneousAccepts } = require('net');

expectWarning(
'DeprecationWarning',
'net._setSimultaneousAccepts() is deprecated and will be removed.',
'DEP0121');

Trott marked this conversation as resolved.
Show resolved Hide resolved
net._setSimultaneousAccepts();
net._setSimultaneousAccepts();
_setSimultaneousAccepts();
_setSimultaneousAccepts();