Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: enable jsdoc/check-param-names lint rule #41311

Merged
merged 2 commits into from Dec 28, 2021
Merged

tools: enable jsdoc/check-param-names lint rule #41311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43371dd
events: clarify JSDoc entries
Trott Dec 24, 2021
f81c627
tools: enable jsdoc/check-param-names lint rule
Trott Dec 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion .eslintrc.js
View file
Open in desktop
Expand Up @@ -350,7 +350,6 @@ module.exports = {
'jsdoc/check-tag-names': 'off',
'jsdoc/require-returns': 'off',
'jsdoc/require-property-description': 'off',
'jsdoc/check-param-names': 'off',

// Custom rules from eslint-plugin-node-core
'node-core/no-unescaped-regexp-dot': 'error',
Expand Down
6 changes: 6 additions & 0 deletions lib/internal/event_target.js
View file
Open in desktop
Expand Up @@ -443,7 +443,13 @@ class EventTarget {
/**
* @callback EventTargetCallback
* @param {Event} event
*/

/**
* @typedef {{ handleEvent: EventTargetCallback }} EventListener
*/

/**
* @param {string} type
* @param {EventTargetCallback|EventListener} listener
* @param {{
Expand Down