Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: improve MakeCallback() performance #41331

Closed
wants to merge 6 commits into from
Closed

src: improve MakeCallback() performance #41331

wants to merge 6 commits into from

Commits on Dec 26, 2021

  1. src: guard slightly costly check in MakeCallback more strongly

    @addaleax
    addaleax committed Dec 26, 2021
    Copy the full SHA
    bb0bd36 View commit details
    Browse the repository at this point in the history

  2. src: store native async execution resources as v8::Local 

    This is possible because the async stack is always expected
to match the native call stack, and saves performance overhead
that comes from the usage of `v8::Global`.
    @addaleax
    addaleax committed Dec 26, 2021
    Copy the full SHA
    f97d04e View commit details
    Browse the repository at this point in the history

  3. src: split out async stack corruption detection from inline fn 

    This is fairly expensive code that unnecessarily bloats the
contents of the inline function.
    @addaleax
    addaleax committed Dec 26, 2021
    Copy the full SHA
    853853f View commit details
    Browse the repository at this point in the history

  4. fixup! src: guard slightly costly check in MakeCallback more strongly

    @addaleax
    addaleax committed Dec 26, 2021
    Copy the full SHA
    b98e4bd View commit details
    Browse the repository at this point in the history

  5. fixup! src: store native async execution resources as v8::Local

    @addaleax
    addaleax committed Dec 26, 2021
    Copy the full SHA
    069373e View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2021

  1. fixup! src: store native async execution resources as v8::Local

    @addaleax
    addaleax committed Dec 28, 2021
    Copy the full SHA
    a7787bb View commit details
    Browse the repository at this point in the history