test: use spawnSync() full name in test-stdio-pipe-stderr #41332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
addaleax
approved these changes
Dec 26, 2021
cjihrig
approved these changes
Dec 26, 2021
tniessen
approved these changes
Dec 27, 2021
RaisinTen
approved these changes
Dec 27, 2021
lpinca
approved these changes
Dec 27, 2021
27 tasks
Trott
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/41332 ✔ Done loading data for nodejs/node/pull/41332 ----------------------------------- PR info ------------------------------------ Title test: use spawnSync() full name in test-stdio-pipe-stderr (#41332) Author Rich Trott (@Trott) Branch Trott:spawnSync-2 -> nodejs:master Labels test, needs-ci Commits 1 - test: use spawnSync() full name in test-stdio-pipe-stderr Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/41332 Reviewed-By: Anna Henningsen Reviewed-By: Colin Ihrig Reviewed-By: Tobias Nießen Reviewed-By: Darshan Sen Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41332 Reviewed-By: Anna Henningsen Reviewed-By: Colin Ihrig Reviewed-By: Tobias Nießen Reviewed-By: Darshan Sen Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 26 Dec 2021 20:34:15 GMT ✔ Approvals: 5 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/41332#pullrequestreview-840112526 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/41332#pullrequestreview-840112775 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/41332#pullrequestreview-840128508 ✔ - Darshan Sen (@RaisinTen): https://github.com/nodejs/node/pull/41332#pullrequestreview-840339264 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41332#pullrequestreview-840509905 ✖ GitHub CI is still running ℹ Last Full PR CI on 2021-12-30T16:01:02Z: https://ci.nodejs.org/job/node-test-pull-request/41688/ - Querying data for job/node-test-pull-request/41688/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1638218637 |
nodejs-github-bot
added
the
commit-queue-failed
test-stdio-pipe-stderr uses `spawnSync()` but renames it as `spawn()` which can be confusing. Rename it to `spawnSync()` for readability/maintainability. PR-URL: nodejs#41332 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in 4e6fc8d |
This was referenced Dec 31, 2021
This was referenced Jan 6, 2022
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
test-stdio-pipe-stderr uses `spawnSync()` but renames it as `spawn()` which can be confusing. Rename it to `spawnSync()` for readability/maintainability. PR-URL: #41332 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
test-stdio-pipe-stderr uses `spawnSync()` but renames it as `spawn()` which can be confusing. Rename it to `spawnSync()` for readability/maintainability. PR-URL: #41332 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
test-stdio-pipe-stderr uses `spawnSync()` but renames it as `spawn()` which can be confusing. Rename it to `spawnSync()` for readability/maintainability. PR-URL: nodejs#41332 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
test-stdio-pipe-stderr uses `spawnSync()` but renames it as `spawn()` which can be confusing. Rename it to `spawnSync()` for readability/maintainability. PR-URL: #41332 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-stdio-pipe-stderr uses
spawnSync()but renames it asspawn()which can be confusing. Rename it to
spawnSync()forreadability/maintainability.