Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: fix benchmark/run.js handling of --set #41334

Merged
merged 1 commit into from Dec 29, 2021
Merged

benchmark: fix benchmark/run.js handling of --set #41334

merged 1 commit into from Dec 29, 2021

Commits on Dec 27, 2021

  1. benchmark: fix benchmark/run.js handling of --set 

    run.js does not work with --set as it tries to include it as
options to `fork()` rather than as part of argv for `fork()`. This
doesn't throw an error because of a quirk in `fork()` that silently
accepts arrays for options objects. This will be changing in Node.js
18.x.
    @Trott
    Trott committed Dec 27, 2021
    Copy the full SHA
    fbd5992 View commit details
    Browse the repository at this point in the history