Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify uncaughtException origin for ESM #41339

Merged
merged 6 commits into from Jan 9, 2022
Merged

doc: clarify uncaughtException origin for ESM #41339

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
df5db76
doc: clarify `uncaughtException` `origin` for ESM
aduh95 Dec 27, 2021
c3b2692
fixup! doc: clarify `uncaughtException` `origin` for ESM
aduh95 Dec 27, 2021
61eb69a
fixup! doc: clarify `uncaughtException` `origin` for ESM
aduh95 Dec 27, 2021
ffe2656
fixup! doc: clarify `uncaughtException` `origin` for ESM
aduh95 Dec 27, 2021
c8d2454
fixup! doc: clarify `uncaughtException` `origin` for ESM
aduh95 Dec 27, 2021
b589d69
fixup! doc: clarify `uncaughtException` `origin` for ESM
aduh95 Dec 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 8 additions & 4 deletions doc/api/process.md
View file
Open in desktop
Expand Up @@ -337,7 +337,7 @@ changes:
rejection or from an synchronous error. Can either be `'uncaughtException'` or
`'unhandledRejection'`. The latter is only used in conjunction with the
[`--unhandled-rejections`][] flag set to `strict` or `throw` and
an unhandled rejection.
an unhandled rejection, or when the entry point is an ES module.
aduh95 marked this conversation as resolved.
Show resolved Hide resolved

The `'uncaughtException'` event is emitted when an uncaught JavaScript
exception bubbles all the way back to the event loop. By default, Node.js
Expand Down Expand Up @@ -365,6 +365,8 @@ setTimeout(() => {
}, 500);

// Intentionally cause an exception, but don't catch it.
// Because the exception happens when evaluating an ES module, this is
// undistinguishable from a Promise rejection, and will be reported as such.
nonexistentFunc();
console.log('This will not run.');
```
Expand Down Expand Up @@ -433,7 +435,7 @@ added:
rejection or from synchronous errors. Can either be `'uncaughtException'` or
`'unhandledRejection'`. The latter is only used in conjunction with the
[`--unhandled-rejections`][] flag set to `strict` or `throw` and
an unhandled rejection.
an unhandled rejection, or when the entry point is an ES module.

The `'uncaughtExceptionMonitor'` event is emitted before an
`'uncaughtException'` event is emitted or a hook installed via
Expand All @@ -451,6 +453,8 @@ process.on('uncaughtExceptionMonitor', (err, origin) => {
});

// Intentionally cause an exception, but don't catch it.
// Because the exception happens when evaluating an ES module, this is
// undistinguishable from a Promise rejection, and will be reported as such.
nonexistentFunc();
// Still crashes Node.js
```
Expand Down Expand Up @@ -503,7 +507,7 @@ process.on('unhandledRejection', (reason, promise) => {

somePromise.then((res) => {
return reportToUser(JSON.pasre(res)); // Note the typo (`pasre`)
}); // No `.catch()` or `.then()`
}); // No `.catch()` or `.then()` or `await`.
```

```cjs
Expand Down Expand Up @@ -531,7 +535,7 @@ function SomeResource() {
}

const resource = new SomeResource();
// no .catch or .then on resource.loaded for at least a turn
// no await, .catch, or .then on resource.loaded for at least a turn
```

```cjs
Expand Down