Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use list for mutable retval rather than tuple #41372

Merged
merged 2 commits into from Jan 5, 2022
Merged

build: use list for mutable retval rather than tuple #41372

merged 2 commits into from Jan 5, 2022

Commits on Jan 1, 2022

  1. build: use list for mutable retval rather than tuple 

    We define `retval` as a tuple and then replace the tuple by "appending"
items with `+=` but that actually creates a new tuple every time.
Because it is intended to be mutable, use a list instead, then return a
tuple from the function, as it should be immutable outside the function.
    @Trott
    Trott committed Jan 1, 2022
    Copy the full SHA
    68cc26e View commit details
    Browse the repository at this point in the history

  2. Update configure.py 

    Co-authored-by: Mestery <mestery@pm.me>
    @Trott @Mesteery
    Trott and Mesteery committed Jan 1, 2022
    Copy the full SHA
    277dc43 View commit details
    Browse the repository at this point in the history