Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove SameValue comparison reference #41460

Merged
merged 1 commit into from Jan 13, 2022
Merged

doc: remove SameValue comparison reference #41460

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 7 additions & 9 deletions doc/api/assert.md
View file
Open in desktop
Expand Up @@ -686,8 +686,7 @@ are recursively evaluated also by the following rules.

### Comparison details

* Primitive values are compared using the [SameValue Comparison][], used by
[`Object.is()`][].
* Primitive values are compared using [`Object.is()`][].
* [Type tags][Object.prototype.toString()] of objects should be the same.
* [`[[Prototype]]`][prototype-spec] of objects are compared using
the [`===` operator][].
Expand Down Expand Up @@ -741,7 +740,7 @@ assert.deepStrictEqual(date, fakeDate);
// - Date {}

assert.deepStrictEqual(NaN, NaN);
// OK, because of the SameValue comparison
// OK because Object.is(NaN, NaN) is true.

// Different unwrapped numbers:
assert.deepStrictEqual(new Number(1), new Number(2));
Expand All @@ -757,7 +756,7 @@ assert.deepStrictEqual(new String('foo'), Object('foo'));
assert.deepStrictEqual(-0, -0);
// OK

// Different zeros using the SameValue Comparison:
// Different zeros:
assert.deepStrictEqual(0, -0);
// AssertionError: Expected inputs to be strictly deep-equal:
// + actual - expected
Expand Down Expand Up @@ -833,7 +832,7 @@ assert.deepStrictEqual(date, fakeDate);
// - Date {}

assert.deepStrictEqual(NaN, NaN);
// OK, because of the SameValue comparison
// OK because Object.is(NaN, NaN) is true.

// Different unwrapped numbers:
assert.deepStrictEqual(new Number(1), new Number(2));
Expand All @@ -849,7 +848,7 @@ assert.deepStrictEqual(new String('foo'), Object('foo'));
assert.deepStrictEqual(-0, -0);
// OK

// Different zeros using the SameValue Comparison:
// Different zeros:
assert.deepStrictEqual(0, -0);
// AssertionError: Expected inputs to be strictly deep-equal:
// + actual - expected
Expand Down Expand Up @@ -1734,7 +1733,7 @@ changes:
* `message` {string|Error}

Tests strict inequality between the `actual` and `expected` parameters as
determined by the [SameValue Comparison][].
determined by [`Object.is()`][].

```mjs
import assert from 'assert/strict';
Expand Down Expand Up @@ -2026,7 +2025,7 @@ changes:
* `message` {string|Error}

Tests strict equality between the `actual` and `expected` parameters as
determined by the [SameValue Comparison][].
determined by [`Object.is()`][].

```mjs
import assert from 'assert/strict';
Expand Down Expand Up @@ -2446,7 +2445,6 @@ argument.

[Object wrappers]: https://developer.mozilla.org/en-US/docs/Glossary/Primitive#Primitive_wrapper_objects_in_JavaScript
[Object.prototype.toString()]: https://tc39.github.io/ecma262/#sec-object.prototype.tostring
[SameValue Comparison]: https://tc39.github.io/ecma262/#sec-samevalue
[`!=` operator]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Inequality
[`===` operator]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Strict_equality
[`==` operator]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Equality
Expand Down