Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix node build failures in WSL Ubuntu #41476

Closed
wants to merge 1 commit into from
Closed

build: fix node build failures in WSL Ubuntu #41476

wants to merge 1 commit into from

Commits on Jan 11, 2022

  1. build: fix node build failures in WSL Ubuntu 

    On WSL systems, `./configure` causes appending of carriage return
(`\r\r`) as leftover and will be appended to the `gyp_args`.
Therefore, it will lead to unhandled exceptions from the `./configure`
execution.
Excluded the empty or whitespace item from the `args` array to
fix the issue.

Fixes: nodejs#41459
    @MrJithil
    MrJithil committed Jan 11, 2022
    Copy the full SHA
    f611dbf View commit details
    Browse the repository at this point in the history