Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14.x backport] esm: make process.exit() default to exit code 0 #41508

Closed
wants to merge 4 commits into from
Closed

[v14.x backport] esm: make process.exit() default to exit code 0 #41508

wants to merge 4 commits into from

Commits on Jan 14, 2022

  1. esm: make process.exit() default to exit code 0 

    Due to a bug in top-level await implementation, it used to default to
exit code 13.

PR-URL: nodejs#41388
Fixes: nodejs#40808
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
    @MoonBall @aduh95
    MoonBall authored and aduh95 committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    968960d View commit details
    Browse the repository at this point in the history

  2. Update lib/internal/modules/esm/handle_process_exit.js 

    Co-authored-by: Richard Lau <rlau@redhat.com>
    @aduh95 @richardlau
    aduh95 and richardlau committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    15e2f48 View commit details
    Browse the repository at this point in the history

  3. fix tests

    @aduh95
    aduh95 committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    0687cbe View commit details
    Browse the repository at this point in the history

  4. fix linter

    @aduh95
    aduh95 committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    8883b4c View commit details
    Browse the repository at this point in the history