Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14.x backport] doc: add note regarding unfinished TLA #41518

Closed
wants to merge 2 commits into from
Closed

[v14.x backport] doc: add note regarding unfinished TLA #41518

wants to merge 2 commits into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 14, 2022

Backport of #41434 and #41516.

@aduh95
doc: add note regarding unfinished TLA
c1d7fcc 
PR-URL: nodejs#41434
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95 aduh95 added doc Issues and PRs related to the documentations. blocked PRs that are blocked by other issues or PRs. experimental Issues and PRs related to experimental features. v14.x labels Jan 14, 2022
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added the esm Issues and PRs related to the ECMAScript Modules implementation. label Jan 14, 2022
@richardlau
Copy link
Member

Is this blocked because #41516 hasn't landed? Or because #41434 hasn't gone out yet in current? Or some other reason?

@aduh95
doc: add missing YAML tag in esm.md
c33418b 
Refs: nodejs#41434

PR-URL: nodejs#41516
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@aduh95 aduh95 removed the blocked PRs that are blocked by other issues or PRs. label Jan 14, 2022
@aduh95
Copy link
Contributor Author

aduh95 commented Jan 14, 2022

Is this blocked because #41516 hasn't landed? Or because #41434 hasn't gone out yet in current? Or some other reason?

It was because #41516 hadn't landed, I should probably have opened a draft PR instead. I've removed the label and I'll now let the LTS team handle that.

richardlau pushed a commit that referenced this pull request Jan 25, 2022
@aduh95 @richardlau
doc: add note regarding unfinished TLA
e903798 
PR-URL: #41434
Backport-PR-URL: #41518
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Jan 25, 2022
@aduh95 @richardlau
doc: add missing YAML tag in esm.md
5971d58 
Refs: #41434

PR-URL: #41516
Backport-PR-URL: #41518
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@richardlau
Copy link
Member

Landed in a90defe...5971d58.

@richardlau richardlau closed this Jan 25, 2022
@aduh95 aduh95 deleted the backport-tla-doc-updates branch January 25, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guybedford guybedford guybedford approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. experimental Issues and PRs related to experimental features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aduh95 @nodejs-github-bot @richardlau @guybedford