Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14.x backport] deps: update ICU to 70.1 #41526

Closed
wants to merge 1 commit into from
Closed

[v14.x backport] deps: update ICU to 70.1 #41526

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Jan 14, 2022

This is a clean cherry-pick of #40658
Opened as a PR to check CI.

@targos
deps: update ICU to 70.1
31ee4e2 
Refs: https://github.com/unicode-org/icu/releases/tag/release-70-1

PR-URL: nodejs#40658
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@targos targos changed the title deps: update ICU to 70.1 [v14.x backport] deps: update ICU to 70.1 Jan 14, 2022
@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. v14.x labels Jan 14, 2022
@targos targos added icu Issues and PRs related to the ICU dependency. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 14, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 14, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41870/

RaisinTen
RaisinTen approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

cjihrig
cjihrig approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@richardlau richardlau added the notable-change PRs with changes that should be highlighted in changelogs. label Jan 14, 2022
@github-actions github-actions bot mentioned this pull request Jan 15, 2022
Open
26 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41896/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41921/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 16, 2022 •
edited by richardlau

CI: https://ci.nodejs.org/job/node-test-pull-request/41924/ (✔️)

@github-actions github-actions bot mentioned this pull request Jan 18, 2022
Open
16 tasks
@targos
Copy link
Member Author

targos commented Jan 18, 2022

Landed in 2755d39

targos added a commit that referenced this pull request Jan 18, 2022
@targos
deps: update ICU to 70.1
2755d39 
Refs: https://github.com/unicode-org/icu/releases/tag/release-70-1

PR-URL: #40658
Backport-PR-URL: #41526
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targos targos closed this Jan 18, 2022
@targos targos deleted the icu-70-v14.x branch January 18, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
icu Issues and PRs related to the ICU dependency. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@targos @nodejs-github-bot @cjihrig @richardlau @RaisinTen