Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: remove unreachable code from crypto/hash-stream-creation #41535

Merged
merged 1 commit into from Jan 17, 2022
Merged

benchmark: remove unreachable code from crypto/hash-stream-creation #41535

merged 1 commit into from Jan 17, 2022

Commits on Jan 15, 2022

  1. benchmark: remove unreachable code from crypto/hash-stream-creation 

    `hash.digest('buffer')` has returned a Buffer and not a string since at
least Node.js 0.10.6. The benchmark, as it is written, will not work on
any version of Node.js prior to 16.x (due to `Object.hasOwn()`) and
certainly won't run on versions earlier than 0.10.6 due to const/let and
probably other things. Remove impossible-to-reach code intended to
accommodate Node.js earlier than 0.10.6.
    @Trott
    Trott committed Jan 15, 2022
    Copy the full SHA
    4215431 View commit details
    Browse the repository at this point in the history