crypto: remove checkIP options argument #41571
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
crypto
jasnell
approved these changes
Jan 17, 2022
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cjihrig
approved these changes
Jan 17, 2022
lpinca
approved these changes
Jan 17, 2022
This comment has been minimized.
This comment has been minimized.
tniessen
changed the title
tniessen
force-pushed
the
tls-remove-x509-checkip-options
branch
from
30b034c
to
fe6b397
Compare
|
@lpinca I've rephrased it in the hope that it will be clearer. If it isn't, I'm happy to go with your suggestion and dropping all RFC-specific terminology. |
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
16 tasks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
13 tasks
None of the supported options have any effect on X509_check_ip_asc. Refs: openssl/openssl#17536
tniessen
force-pushed
the
tls-remove-x509-checkip-options
branch
from
fe6b397
to
431a70a
Compare
|
Rebased due to #41569. |
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
|
Landed in 6d66649, thanks for reviewing. |
tniessen
added a commit
that referenced
this pull request
Jan 19, 2022
None of the supported options have any effect on X509_check_ip_asc. Refs: openssl/openssl#17536 PR-URL: #41571 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
tniessen
added a commit
to tniessen/node
that referenced
this pull request
Jan 19, 2022
Wildcard options do not affect X509_check_email. Refs: openssl/openssl#17536 Refs: nodejs#41571
This was referenced Jan 20, 2022
panva
pushed a commit
that referenced
this pull request
Jan 22, 2022
Wildcard options do not affect X509_check_email. Refs: openssl/openssl#17536 Refs: #41571 PR-URL: #41599 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
This was referenced Jan 23, 2022
BethGriggs
pushed a commit
that referenced
this pull request
Jan 25, 2022
None of the supported options have any effect on X509_check_ip_asc. Refs: openssl/openssl#17536 PR-URL: #41571 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Jan 25, 2022
Wildcard options do not affect X509_check_email. Refs: openssl/openssl#17536 Refs: #41571 PR-URL: #41599 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
None of the supported options have any effect on X509_check_ip_asc. Refs: openssl/openssl#17536 PR-URL: nodejs#41571 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
Wildcard options do not affect X509_check_email. Refs: openssl/openssl#17536 Refs: nodejs#41571 PR-URL: nodejs#41599 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 28, 2022
None of the supported options have any effect on X509_check_ip_asc. Refs: openssl/openssl#17536 PR-URL: #41571 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 28, 2022
Wildcard options do not affect X509_check_email. Refs: openssl/openssl#17536 Refs: #41571 PR-URL: #41599 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 2, 2022
None of the supported options have any effect on X509_check_ip_asc. Refs: openssl/openssl#17536 PR-URL: #41571 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 2, 2022
Wildcard options do not affect X509_check_email. Refs: openssl/openssl#17536 Refs: #41571 PR-URL: #41599 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 3, 2022
None of the supported options have any effect on X509_check_ip_asc. Refs: openssl/openssl#17536 PR-URL: #41571 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 3, 2022
Wildcard options do not affect X509_check_email. Refs: openssl/openssl#17536 Refs: #41571 PR-URL: #41599 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 14, 2022
None of the supported options have any effect on X509_check_ip_asc. Refs: openssl/openssl#17536 PR-URL: #41571 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 14, 2022
Wildcard options do not affect X509_check_email. Refs: openssl/openssl#17536 Refs: #41571 PR-URL: #41599 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of the supported options have any effect on
X509_check_ip_asc.(
iPAddressis not a typo, it is what RFC 5280 calls subject alternative names that are IP addresses.)Refs: openssl/openssl#17536