Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: use sentence case for Web Crypto headers #41577

Closed
wants to merge 1 commit into from
Closed

doc: use sentence case for Web Crypto headers #41577

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

Refs: #33889

@tniessen tniessen requested a review from Trott January 18, 2022 13:11
@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Jan 18, 2022
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 18, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

tniessen added a commit that referenced this pull request Jan 18, 2022
@tniessen
doc: use sentence case for Web Crypto headers
98659c0 
Refs: #33889

PR-URL: #41577
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
@tniessen
Copy link
Member Author

Landed in 98659c0, thanks for reviewing.

@tniessen tniessen closed this Jan 18, 2022
thedull pushed a commit to thedull/node that referenced this pull request Jan 18, 2022
@tniessen @thedull
doc: use sentence case for Web Crypto headers
5e20284 
Refs: nodejs#33889

PR-URL: nodejs#41577
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
@tniessen @BethGriggs
doc: use sentence case for Web Crypto headers
9ea8e49 
Refs: #33889

PR-URL: #41577
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@tniessen @Linkgoron
doc: use sentence case for Web Crypto headers
5a2a5d7 
Refs: nodejs#33889

PR-URL: nodejs#41577
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Feb 26, 2022
@tniessen @danielleadams
doc: use sentence case for Web Crypto headers
01283f6 
Refs: #33889

PR-URL: #41577
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Mesteery Mesteery Mesteery approved these changes

Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tniessen @Trott @lpinca @cjihrig @Mesteery @nodejs-github-bot