Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools,test,lib: enable no-cond-assign ESLint rule #41614

Merged
merged 9 commits into from
Jan 23, 2022
Merged

tools,test,lib: enable no-cond-assign ESLint rule #41614

merged 9 commits into from
Jan 23, 2022

Commits on Jan 23, 2022

  1. crypto: revise variables for const use instead of let 

    This prepares the code for enabling the no-cond-assign rule.

PR-URL: nodejs#41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @Trott
    Trott committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    c05c883 View commit details
    Browse the repository at this point in the history

  2. stream: check for null instead of falsy in loops 

    Check for null in while loops. This is preparing the code for
the no-cond-assign ESLint rule.

PR-URL: nodejs#41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @Trott
    Trott committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    e6fdcbe View commit details
    Browse the repository at this point in the history

  3. policy: check for null instead of falsy in loop 

    This prepares the code for the no-cond-assign ESLint rule.

PR-URL: nodejs#41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @Trott
    Trott committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    0bc6422 View commit details
    Browse the repository at this point in the history

  4. process: check for null instead of falsy in while loop 

    This prepares the code for the no-cond-assign ESLint rule.

PR-URL: nodejs#41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @Trott
    Trott committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    e044a5d View commit details
    Browse the repository at this point in the history

  5. timers: check for nullish instead of falsy in loops 

    This prepares the code for the no-cond-assign ESLint rule.

PR-URL: nodejs#41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @Trott
    Trott committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    bd42245 View commit details
    Browse the repository at this point in the history

  6. util: check for null instead of flasy in loop 

    This prepares the code for the no-cond-assign ESLint rule.

PR-URL: nodejs#41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @Trott
    Trott committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    ac06951 View commit details
    Browse the repository at this point in the history

  7. repl: check for precise values rather than falsy in loops 

    This prepares the code for the no-cond-assign ESLint rule.

PR-URL: nodejs#41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @Trott
    Trott committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    348469b View commit details
    Browse the repository at this point in the history

  8. test: prepare tests for no-cond-assign ESLint rule 

    PR-URL: nodejs#41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @Trott
    Trott committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    d77754b View commit details
    Browse the repository at this point in the history

  9. tools: enable no-cond-assign-ESLint rule 

    no-cond-assign is one of the few ESLint recommended rules that we have
turned off. This change enables the rule.

PR-URL: nodejs#41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @Trott
    Trott committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    68bb83f View commit details
    Browse the repository at this point in the history