vm: update measure memory rejection information #41639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
yashLadha
force-pushed
the
update_vm_measure_memory_doc
branch
from
f5e04e8
to
8c9a9b7
Compare
yashLadha
changed the title
|
Can you change the subsystem in the commit message to |
Trott
reviewed
Jan 22, 2022
benjamingr
reviewed
Jan 22, 2022
yashLadha
force-pushed
the
update_vm_measure_memory_doc
branch
from
8c9a9b7
to
7aa8305
Compare
If in case context is unable to allocate a promise then `ERR_CONTEXT_NOT_INITIALIZED` error will be thrown (as promise rejection) in the vm measureMemory call.
yashLadha
force-pushed
the
update_vm_measure_memory_doc
branch
from
7aa8305
to
18f3edd
Compare
Updated to use |
aduh95
reviewed
Jan 22, 2022
jasnell
approved these changes
Jan 28, 2022
|
This could land i think? just one linter failure ping @yashLadha |
|
Sure, will update the PR |
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
debadree25
approved these changes
May 13, 2023
debadree25
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in 8115c2f |
targos
pushed a commit
that referenced
this pull request
May 14, 2023
If in case context is unable to allocate a promise then `ERR_CONTEXT_NOT_INITIALIZED` error will be thrown (as promise rejection) in the vm measureMemory call. PR-URL: #41639 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 15, 2023
If in case context is unable to allocate a promise then `ERR_CONTEXT_NOT_INITIALIZED` error will be thrown (as promise rejection) in the vm measureMemory call. PR-URL: #41639 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
If in case context is unable to allocate a promise then `ERR_CONTEXT_NOT_INITIALIZED` error will be thrown (as promise rejection) in the vm measureMemory call. PR-URL: #41639 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
If in case context is unable to allocate a promise then `ERR_CONTEXT_NOT_INITIALIZED` error will be thrown (as promise rejection) in the vm measureMemory call. PR-URL: nodejs#41639 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If in case current context is unable to allocate a promise then
ERR_CONTEXT_NOT_INITIALIZEDerror will be thrown (as promise rejection) in the vm measureMemory call. Though minor change but this behavior should also be notified in the docs for the API call.