Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: fix write methods param validation and docs #41677

Merged
merged 14 commits into from Apr 4, 2022
Merged

fs: fix write methods param validation and docs #41677

merged 14 commits into from Apr 4, 2022

Commits on Apr 3, 2022

  1. fs: make promises/write and writeSync params optional 

    This change allows passing objects as "named parameters" and
prohibits passing objects with own toString property as strings.

Fixes: nodejs#41666
    @LiviaMedeiros
    LiviaMedeiros committed Apr 3, 2022
    Copy the full SHA
    1c15fcd View commit details
    Browse the repository at this point in the history

  2. squash: add tests for filehandle.write and fs.writeSync

    @LiviaMedeiros
    LiviaMedeiros committed Apr 3, 2022
    Copy the full SHA
    fe6a9ea View commit details
    Browse the repository at this point in the history

  3. squash: add test cases for stringable objects

    @LiviaMedeiros
    LiviaMedeiros committed Apr 3, 2022
    Copy the full SHA
    e93fd9c View commit details
    Browse the repository at this point in the history

  4. squash: add test cases for fs.write

    @LiviaMedeiros
    LiviaMedeiros committed Apr 3, 2022
    Copy the full SHA
    1358d5f View commit details
    Browse the repository at this point in the history

  5. squash: adjust default length value

    @LiviaMedeiros
    LiviaMedeiros committed Apr 3, 2022
    Copy the full SHA
    b3d04aa View commit details
    Browse the repository at this point in the history

  6. squash: harden string validation in fh.writeFile and fh.appendFile

    @LiviaMedeiros
    LiviaMedeiros committed Apr 3, 2022
    Copy the full SHA
    720ef24 View commit details
    Browse the repository at this point in the history

  7. squash: remove unused optional chaining 

    Refs: nodejs#42518
    @LiviaMedeiros
    LiviaMedeiros committed Apr 3, 2022
    Copy the full SHA
    ac6f1df View commit details
    Browse the repository at this point in the history

  8. squash: add changelog entry for filehandle.appendFile

    @LiviaMedeiros
    LiviaMedeiros committed Apr 3, 2022
    Copy the full SHA
    da8086f View commit details
    Browse the repository at this point in the history

  9. squash: remove redundant changelog entries 

    string-oriented changes do not affect buffer-oriented methods
    @LiviaMedeiros
    LiviaMedeiros committed Apr 3, 2022
    Copy the full SHA
    a283264 View commit details
    Browse the repository at this point in the history

  10. squash: remove redundant changelog entry 

    string-oriented changes do not affect buffer-oriented methods
    @LiviaMedeiros
    LiviaMedeiros committed Apr 3, 2022
    Copy the full SHA
    f3b05dd View commit details
    Browse the repository at this point in the history

  11. squash: annihilate changelog entries 

    Said code caused process abortions
    @LiviaMedeiros
    LiviaMedeiros committed Apr 3, 2022
    Copy the full SHA
    bbf49e7 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2022

  1. squash: remove redundant changelog entry

    @LiviaMedeiros
    LiviaMedeiros committed Apr 4, 2022
    Copy the full SHA
    037561c View commit details
    Browse the repository at this point in the history

  2. squash: remove "named params" support 

    This is going to be introduced separately
    @LiviaMedeiros
    LiviaMedeiros committed Apr 4, 2022
    Copy the full SHA
    847749f View commit details
    Browse the repository at this point in the history

  3. squash: fix docs for fsPromises.writeFile

    @LiviaMedeiros
    LiviaMedeiros committed Apr 4, 2022
    Copy the full SHA
    a702039 View commit details
    Browse the repository at this point in the history