Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make worker-take-heapsnapshot non-flaky #41684

Closed
wants to merge 1 commit into from
Closed

test: make worker-take-heapsnapshot non-flaky #41684

wants to merge 1 commit into from

Conversation

mhdawson
Copy link
Member

Recent V8 upgrade seems to have made this pass
reliably now. Remove flaky entry

Signed-off-by: Michael Dawson mdawson@devrus.com

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 24, 2022
@mhdawson mhdawson mentioned this pull request Jan 24, 2022
Closed
@mhdawson
Copy link
Member Author

For more details see #41204

Trott
Trott approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a Closes: https://github.com/nodejs/node/issues/41204 to the commit message?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42141/

RaisinTen
RaisinTen approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we backport this to v14.x?

@mhdawson
test: make worker-take-heapsnapshot non-flaky
491f75d 
Recent V8 upgrade seems to have made this pass
reliably now. Remove flaky entry

Refs: nodejs#41204

Signed-off-by: Michael Dawson <mdawson@devrus.com>
@mhdawson
Copy link
Member Author

@RaisinTen I don't think we ever backported the original exclude to any of the released lines as the CI does not run the arm-debug step except for on the main branch.

@mhdawson
Copy link
Member Author

@Trott I don't think a closes makes sense the issue still exists for some of the older lines. I will add a Refs: though.

@mhdawson
Copy link
Member Author

Added the refs

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42148/

@github-actions github-actions bot mentioned this pull request Jan 26, 2022
Open
26 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42175/

@github-actions github-actions bot mentioned this pull request Jan 27, 2022
Open
30 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42191/

@github-actions github-actions bot mentioned this pull request Jan 28, 2022
Open
22 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42202/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42203/

This was referenced Jan 29, 2022
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42275/

mhdawson added a commit that referenced this pull request Jan 31, 2022
@mhdawson
test: make worker-take-heapsnapshot non-flaky
0ff62b4 
Recent V8 upgrade seems to have made this pass
reliably now. Remove flaky entry

Refs: #41204

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41684
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@mhdawson
Copy link
Member Author

Landed in 0ff62b4

@mhdawson mhdawson closed this Jan 31, 2022
@github-actions github-actions bot mentioned this pull request Feb 1, 2022
Open
31 tasks
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@mhdawson @ruyadorno
test: make worker-take-heapsnapshot non-flaky
9c704b1 
Recent V8 upgrade seems to have made this pass
reliably now. Remove flaky entry

Refs: #41204

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41684
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@mhdawson @danielleadams
test: make worker-take-heapsnapshot non-flaky
ab92baa 
Recent V8 upgrade seems to have made this pass
reliably now. Remove flaky entry

Refs: #41204

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41684
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@mhdawson @danielleadams
test: make worker-take-heapsnapshot non-flaky
b47b25f 
Recent V8 upgrade seems to have made this pass
reliably now. Remove flaky entry

Refs: #41204

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41684
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@mhdawson @danielleadams
test: make worker-take-heapsnapshot non-flaky
1f65620 
Recent V8 upgrade seems to have made this pass
reliably now. Remove flaky entry

Refs: #41204

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41684
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@mhdawson @nodejs-github-bot @jasnell @Trott @benjamingr @lpinca @richardlau @RaisinTen