Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix and cleanup URL::SerializeURL #41759

Closed
wants to merge 6 commits into from
Closed

src: fix and cleanup URL::SerializeURL #41759

wants to merge 6 commits into from

Commits on Jan 29, 2022

  1. src: fix query/fragment serialization in URL::SerializeURL 

    These are presumably typos.
    @addaleax
    addaleax committed Jan 29, 2022
    Copy the full SHA
    b47430c View commit details
    Browse the repository at this point in the history

  2. src: reserve string allocation space early in URL::SerializeURL 

    This can be useful for performance when doing many string
concatenations.
    @addaleax
    addaleax committed Jan 29, 2022
    Copy the full SHA
    c9ea544 View commit details
    Browse the repository at this point in the history

  3. src: use const reference instead of pointer in URL::SerializeURL 

    Just some general cleanup to make things C++-y instead of C-y.
    @addaleax
    addaleax committed Jan 29, 2022
    Copy the full SHA
    2fe8dcf View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2022

  1. fixup! src: use const reference instead of pointer in URL::SerializeURL 

    Co-authored-by: Timothy Gu <timothygu99@gmail.com>
    @addaleax @TimothyGu
    addaleax and TimothyGu committed Jan 31, 2022
    Copy the full SHA
    438849a View commit details
    Browse the repository at this point in the history

  2. fixup! src: use const reference instead of pointer in URL::SerializeURL

    @addaleax
    addaleax committed Jan 31, 2022
    Copy the full SHA
    6552e41 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2022

  1. fixup! src: use const reference instead of pointer in URL::SerializeURL 

    Co-authored-by: James M Snell <jasnell@gmail.com>
    @addaleax @jasnell
    addaleax and jasnell committed Feb 7, 2022
    Copy the full SHA
    08ec1d5 View commit details
    Browse the repository at this point in the history