Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v16.x] Fix JS linting warnings and errors #41805

Closed
wants to merge 2 commits into from
Closed

[v16.x] Fix JS linting warnings and errors #41805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9767fc9
lib: fix linting warnings and errors
danielleadams Feb 1, 2022
58f1200
test: add ignore for regex space rule
danielleadams Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/internal/bootstrap/node.js
View file
Open in desktop
Expand Up @@ -56,7 +56,7 @@ const {
} = primordials;
const config = internalBinding('config');
const internalTimers = require('internal/timers');
const { deprecate, lazyDOMExceptionClass } = require('internal/util');
const { deprecate } = require('internal/util');
targos marked this conversation as resolved.
Show resolved Hide resolved

setupProcessObject();

Expand Down
9 changes: 0 additions & 9 deletions lib/internal/streams/utils.js
View file
Open in desktop
Expand Up @@ -6,7 +6,6 @@ const {
SymbolIterator,
} = primordials;

const kDestroyed = Symbol('kDestroyed');
const kIsErrored = Symbol('kIsErrored');
const kIsReadable = Symbol('kIsReadable');
const kIsDisturbed = Symbol('kIsDisturbed');
Expand Down Expand Up @@ -112,14 +111,6 @@ function isReadableFinished(stream, strict) {
);
}

function isDisturbed(stream) {
return !!(stream && (
stream.readableDidRead ||
stream.readableAborted ||
stream[kIsDisturbed]
));
}

function isReadable(stream) {
if (stream && stream[kIsReadable] != null) return stream[kIsReadable];
const r = isReadableNodeStream(stream);
Expand Down
6 changes: 5 additions & 1 deletion lib/readline.js
View file
Open in desktop
Expand Up @@ -1283,7 +1283,11 @@ Interface.prototype._ttyWrite = function(s, key) {
/**
* Creates an `AsyncIterator` object that iterates through
* each line in the input stream as a string.
* @returns {Symbol.AsyncIterator}
* @typedef {{
* [Symbol.asyncIterator]: () => InterfaceAsyncIterator,
* next: () => Promise<string>
* }} InterfaceAsyncIterator
* @returns {InterfaceAsyncIterator}
*/
Interface.prototype[SymbolAsyncIterator] = function() {
if (this[kLineObjectStream] === undefined) {
Expand Down
1 change: 1 addition & 0 deletions test/parallel/test-v8-untrusted-code-mitigations.js
View file
Open in desktop
Expand Up @@ -15,4 +15,5 @@ assert.notStrictEqual(untrustedFlag, -1);
const nextFlag = v8Options.indexOf('--', untrustedFlag + 2);
const slice = v8Options.substring(untrustedFlag, nextFlag);

// eslint-disable-next-line no-regex-spaces
assert(slice.match(/type: bool default: false/));