Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: support copy of relative links with cp and cpSync #41819

Merged
merged 12 commits into from Feb 15, 2022
Merged

fs: support copy of relative links with cp and cpSync #41819

merged 12 commits into from Feb 15, 2022

Commits on Feb 8, 2022

  1. fs: support copy of relative links with cp and cpSync 

    Fixes: nodejs#41693
    @marcosbc
    marcosbc committed Feb 8, 2022
    Copy the full SHA
    eed1481 View commit details
    Browse the repository at this point in the history

  2. Fix linter warning 

    Signed-off-by: Marcos Bjoerkelund <marcosbd@vmware.com>
    @marcosbc
    marcosbc committed Feb 8, 2022
    Copy the full SHA
    65d214c View commit details
    Browse the repository at this point in the history

  3. Ensure 'absolute' is a boolean and true by default 

    Signed-off-by: Marcos Bjoerkelund <marcosbd@vmware.com>
    @marcosbc
    marcosbc committed Feb 8, 2022
    Copy the full SHA
    f3bd1f2 View commit details
    Browse the repository at this point in the history

  4. Change absolute approach to verbatimSymlinks 

    Signed-off-by: Marcos Bjoerkelund <marcosbd@vmware.com>
    @marcosbc
    marcosbc committed Feb 8, 2022
    Copy the full SHA
    df8024d View commit details
    Browse the repository at this point in the history

  5. Add changes entries in YAML docs for fs.cp/fs.cpSync/fs.promises.cp 

    Signed-off-by: Marcos Bjoerkelund <marcosbd@vmware.com>
    @marcosbc
    marcosbc committed Feb 8, 2022
    Copy the full SHA
    3071c63 View commit details
    Browse the repository at this point in the history

  6. Fix linter warning 

    Signed-off-by: Marcos Bjoerkelund <marcosbd@vmware.com>
    @marcosbc
    marcosbc committed Feb 8, 2022
    Copy the full SHA
    4c1324e View commit details
    Browse the repository at this point in the history

  7. Apply wording suggestions 

    Signed-off-by: Marcos Bjoerkelund <marcosbd@vmware.com>
    @marcosbc
    marcosbc committed Feb 8, 2022
    Copy the full SHA
    26c333a View commit details
    Browse the repository at this point in the history

  8. Add suggested validations 

    Signed-off-by: Marcos Bjoerkelund <marcosbd@vmware.com>
    @marcosbc
    marcosbc committed Feb 8, 2022
    Copy the full SHA
    5d7756a View commit details
    Browse the repository at this point in the history

  9. options.dereference and options.verbatimSymlink should be mutually ex… 

    …clusive

Signed-off-by: Marcos Bjoerkelund <marcosbd@vmware.com>
    @marcosbc
    marcosbc committed Feb 8, 2022
    Copy the full SHA
    4cd07ac View commit details
    Browse the repository at this point in the history

  10. Fix error type used for tests 

    Signed-off-by: Marcos Bjoerkelund <marcosbd@vmware.com>
    @marcosbc
    marcosbc committed Feb 8, 2022
    Copy the full SHA
    aa29c91 View commit details
    Browse the repository at this point in the history

  11. Implement feedback: Fix descriptions, use ERR_INCOMPATIBLE_OPTION_PAIR 

    Signed-off-by: Marcos Bjoerkelund <marcosbd@vmware.com>
    @marcosbc
    marcosbc committed Feb 8, 2022
    Copy the full SHA
    eecce13 View commit details
    Browse the repository at this point in the history

  12. Remove unrelated file 

    Signed-off-by: Marcos Bjoerkelund <marcosbd@vmware.com>
    @marcosbc
    marcosbc committed Feb 8, 2022
    Copy the full SHA
    7527fdc View commit details
    Browse the repository at this point in the history