Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: rename X509_NAME_FLAGS #42001

Merged
merged 1 commit into from Feb 17, 2022
Merged

crypto: rename X509_NAME_FLAGS #42001

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/crypto/crypto_common.cc
View file
Open in desktop
Expand Up @@ -41,7 +41,7 @@ using v8::Undefined;
using v8::Value;

namespace crypto {
static constexpr int X509_NAME_FLAGS =
static constexpr int kX509NameFlagsMultiline =
ASN1_STRFLGS_ESC_2253 |
ASN1_STRFLGS_ESC_CTRL |
ASN1_STRFLGS_UTF8_CONVERT |
Expand Down Expand Up @@ -940,7 +940,11 @@ MaybeLocal<Value> GetIssuerString(
const BIOPointer& bio,
X509* cert) {
X509_NAME* issuer_name = X509_get_issuer_name(cert);
if (X509_NAME_print_ex(bio.get(), issuer_name, 0, X509_NAME_FLAGS) <= 0) {
if (X509_NAME_print_ex(
bio.get(),
issuer_name,
0,
kX509NameFlagsMultiline) <= 0) {
USE(BIO_reset(bio.get()));
return Undefined(env->isolate());
}
Expand All @@ -956,7 +960,7 @@ MaybeLocal<Value> GetSubject(
bio.get(),
X509_get_subject_name(cert),
0,
X509_NAME_FLAGS) <= 0) {
kX509NameFlagsMultiline) <= 0) {
USE(BIO_reset(bio.get()));
return Undefined(env->isolate());
}
Expand Down