stream: allow returning null from pipeline tail #42078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
|
@nodejs/streams |
ronag
added
request-ci
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
Feb 22, 2022
benjamingr
approved these changes
Feb 23, 2022
mcollina
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/42078 ✔ Done loading data for nodejs/node/pull/42078 ----------------------------------- PR info ------------------------------------ Title stream: allow returning null from pipeline tail (#42078) Author Robert Nagy (@ronag) Branch ronag:pipeline-null -> nodejs:master Labels stream Commits 1 - stream: allow returning null from pipeline tail Committers 1 - Robert Nagy PR-URL: https://github.com/nodejs/node/pull/42078 Reviewed-By: Matteo Collina Reviewed-By: James M Snell Reviewed-By: Benjamin Gruenbaum ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42078 Reviewed-By: Matteo Collina Reviewed-By: James M Snell Reviewed-By: Benjamin Gruenbaum -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 22 Feb 2022 14:32:00 GMT ✔ Approvals: 3 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/42078#pullrequestreview-889935566 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/42078#pullrequestreview-889955872 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/42078#pullrequestreview-890894764 ✖ This PR needs to wait 24 more hours to land ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-02-23T13:23:52Z: https://ci.nodejs.org/job/node-test-pull-request/42739/ - Querying data for job/node-test-pull-request/42739/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1887812437 |
Mesteery
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 1b47866 |
sxa
pushed a commit
to sxa/node
that referenced
this pull request
Mar 7, 2022
PR-URL: nodejs#42078 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
PR-URL: nodejs#42078 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
|
This won't land clean in v16.x until #40881 is backported to v16.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.