Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url, src: modify one special_back_slash always equals to false #42112

Closed
wants to merge 2 commits into from
Closed

url, src: modify one special_back_slash always equals to false #42112

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6236442
url: remove a line of dead code
XadillaX Feb 24, 2022
7b6d02d
Update node_url.cc
XadillaX Feb 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/node_url.cc
View file
Open in desktop
Expand Up @@ -932,7 +932,10 @@ void URL::Parse(const char* input,
url->flags &= ~URL_FLAGS_SPECIAL;
special = false;
}
special_back_slash = (special && ch == '\\');
// `special_back_slash` equals to `(special && ch == '\\')` and `ch`
// here always not equals to `\\`. So `special_back_slash` here always
// equals to `false`.
special_back_slash = false;
buffer.clear();
if (has_state_override)
return;
Expand Down