Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: Adjust default length for fs.readSync and fsPromises/read #42128

Merged
merged 6 commits into from Feb 27, 2022
Merged

fs: Adjust default length for fs.readSync and fsPromises/read #42128

merged 6 commits into from Feb 27, 2022

Commits on Feb 25, 2022

  1. fs: adjust default length for fs.readSync and fsPromises/read 

    Makes default length reasonable when nonzero offset is set.
    @LiviaMedeiros
    LiviaMedeiros committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    6753ad2 View commit details
    Browse the repository at this point in the history

  2. doc: adjust default length for fs.readSync 

    Makes default length reasonable when nonzero offset is set.
    @LiviaMedeiros
    LiviaMedeiros committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    a836687 View commit details
    Browse the repository at this point in the history

  3. fs: replace default object with null-prototyped 

    To prevent glitches if Object.prototype has been mutated.
    @LiviaMedeiros
    LiviaMedeiros committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    c6f3897 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2022

  1. test: expand fs.readSync tests

    @LiviaMedeiros
    LiviaMedeiros committed Feb 26, 2022
    Configuration menu
    Copy the full SHA
    d933f01 View commit details
    Browse the repository at this point in the history

  2. squash: lint

    @LiviaMedeiros
    LiviaMedeiros committed Feb 26, 2022
    Configuration menu
    Copy the full SHA
    fda600e View commit details
    Browse the repository at this point in the history

  3. Update test/parallel/test-fs-readSync-optional-params.js 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @LiviaMedeiros @aduh95
    LiviaMedeiros and aduh95 committed Feb 26, 2022
    Configuration menu
    Copy the full SHA
    c2fdd45 View commit details
    Browse the repository at this point in the history