Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esm: fix base URL for network imports #42131

Closed
wants to merge 6 commits into from
Closed

esm: fix base URL for network imports #42131

wants to merge 6 commits into from
+79 −16

Commits on Mar 2, 2022

  1. esm: fix base URL for network imports

    @bmeck
    bmeck committed Mar 2, 2022
    Copy the full SHA
    be6806b View commit details
    Browse the repository at this point in the history

  2. fixup: lint

    @bmeck
    bmeck committed Mar 2, 2022
    Copy the full SHA
    03f54a8 View commit details
    Browse the repository at this point in the history

  3. fixup: Update lib/internal/modules/esm/loader.js 

    Co-authored-by: Mestery <mestery@protonmail.com>
    @bmeck @Mesteery
    bmeck and Mesteery committed Mar 2, 2022
    Copy the full SHA
    b9c145a View commit details
    Browse the repository at this point in the history

  4. fixup: Apply suggestions from code review 

    Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    @bmeck @VoltrexKeyva
    bmeck and VoltrexKeyva committed Mar 2, 2022
    Copy the full SHA
    c336ad0 View commit details
    Browse the repository at this point in the history

  5. fixup: assert baseURL is a string for network modules

    @bmeck
    bmeck committed Mar 2, 2022
    Copy the full SHA
    e0da1a3 View commit details
    Browse the repository at this point in the history

  6. fixup: apply code review changes

    @bmeck
    bmeck committed Mar 2, 2022
    Copy the full SHA
    d6e8326 View commit details
    Browse the repository at this point in the history