Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: perform minor cleanups on zlib code #42247

Merged
merged 1 commit into from Mar 10, 2022

Commits on Mar 7, 2022

  1. src: perform minor cleanups on zlib code

    - Use `final` to indicate the classes that we actually
      instantiate
    - Properly use `const` (and the necessary associated `const_cast`
      for zlib because we don’t define `ZLIB_CONST` and allow shared
      builds)
    - Store the JS callback in an internal field rather than a `Global`
      (which improves memory leak debugging capabilities, removes
      a potential future memory leak footgun, and aligns the code
      with the rest of the codebase more closely)
    - Other minor C++ cleanup
    addaleax committed Mar 7, 2022
    Copy the full SHA
    fcd4fe4 View commit details
    Browse the repository at this point in the history