Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve https_renew_cert.sh script #42343

Merged

Commits on Mar 15, 2022

  1. test: improve https_renew_cert.sh script

    - To avoid unnecessarily large diffs, only generate a new private key
      if necessary. Otherwise, reuse the existing private key and only
      issue a new certificate.
    - Remove an unnecessary conversion step using openssl rsa and the
      intermediate rsa.pem and csr.pem files.
    - Extend the certificate validity from 1 year to 10 years.
    - Show a text representation of the issued certificate upon completion
      such that the user can verify the validity.
    - Make the script executable.
    - Use "#!/usr/bin/env bash" instead of "#!/bin/bash".
    - Allow the script to be called from any directory.
    
    Refs: nodejs#42342
    Refs: nodejs#37990
    tniessen committed Mar 15, 2022
    Copy the full SHA
    1a2391d View commit details
    Browse the repository at this point in the history