[v12.x] build: pin Windows GitHub runner to windows-2019

[richardlau]

GitHub is removing the Windows 2016 runner image on March 15, 2022.

Refs: https://github.blog/changelog/2021-10-19-github-actions-the-windows-2016-runner-image-will-be-removed-from-github-hosted-runners-on-march-15-2022/

---

March 15, 2022 is today 😰. They're not gone yet -- #42348 is running on them, but we'll need to move.

[nodejs-github-bot]

Review requested:

• @nodejs/actions

[richardlau]

Hmm, that didn't work https://github.com/nodejs/node/runs/5558888762?check_suite_focus=true 😞
It looked like Node.js 12 should be able to build with VS 2019:

node/vcbuild.bat

Lines 295 to 311 in 3901891

	@rem check if VS2019 is already setup, and for the requested arch
	if "_%VisualStudioVersion%_" == "_16.0_" if "_%VSCMD_ARG_TGT_ARCH%_"=="_%target_arch%_" goto found_vs2019
	@rem need to clear VSINSTALLDIR for vcvarsall to work as expected
	set "VSINSTALLDIR="
	@rem prevent VsDevCmd.bat from changing the current working directory
	set "VSCMD_START_DIR=%CD%"
	set vcvars_call="%VCINSTALLDIR%\Auxiliary\Build\vcvarsall.bat" %vcvarsall_arg%
	echo calling: %vcvars_call%
	call %vcvars_call%
	if errorlevel 1 goto msbuild-not-found
	if defined DEBUG_HELPER @ECHO ON
	:found_vs2019
	echo Found MSVS version %VisualStudioVersion%
	set GYP_MSVS_VERSION=2019
	set PLATFORM_TOOLSET=v142
	goto msbuild-found

[richardlau]

Hmm, that didn't work https://github.com/nodejs/node/runs/5558888762?check_suite_focus=true 😞

Needed to change

node/vcbuild.bat

Line 247 in 3901891

if "_%VCINSTALLDIR%_" == "__" goto msbuild-not-found

so that it searches for VS2019 when it fails to find VS2017: 94956e0

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/43057/

[richardlau]

cc @nodejs/platform-windows @nodejs/build-files

[richardlau]

Fast-track has been requested by @richardlau. Please 👍 to approve.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/43058/

[Mesteery]

I'm not sure if the fast-track label/comment thing works for v12.x.

I don't think it's normal that it doesn't work.

By the way, I have modified your message so that there are no problems with ncu.

[aduh95]

I'm not sure if the fast-track label/comment thing works for v12.x.

I don't think it's normal that it doesn't work.

I think it is, the workflow hasn't been backported to v12.x-staging: https://github.com/nodejs/node/tree/v12.x-staging/.github/workflows

[Mesteery]

Oh right, I thought it was the workflows of the main branch that took precedence.

[richardlau]

Landed in 4ee4490...a64a3ca.