Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v17.8.0 proposal #42425

Merged
merged 70 commits into from Mar 22, 2022
Merged

v17.8.0 proposal #42425

merged 70 commits into from Mar 22, 2022

Commits on Mar 20, 2022

  1. src: fix unchecked return warning from coverity

    Fix unchecked return warning from coverity in
    src/env.cc. Added check in same manner as other
    places where uv_async_init is called.
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #42176
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    mhdawson authored and bengl committed Mar 20, 2022
    Copy the full SHA
    62d9a7f View commit details
    Browse the repository at this point in the history
  2. doc: readline 'line' event emits final line

    Updated docs to reflect current behaviour of readline:
    final line of input will be emitted via `'line'` event
    when input stream `'end'` event is emitted even when
    the input is not newline terminated.
    
    Refs: nodejs/node-v0.x-archive#7238
    
    PR-URL: #42214
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    mattpr authored and bengl committed Mar 20, 2022
    Copy the full SHA
    19851f8 View commit details
    Browse the repository at this point in the history
  3. crypto: add CHECKs to remaining BIO_s_mem allocs

    PR-URL: #42155
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    tniessen authored and bengl committed Mar 20, 2022
    Copy the full SHA
    a4632a3 View commit details
    Browse the repository at this point in the history
  4. tools: fix web streams API links

    PR-URL: #42153
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mscdex authored and bengl committed Mar 20, 2022
    Copy the full SHA
    e95426f View commit details
    Browse the repository at this point in the history
  5. meta: add dependencies label to label-pr-config

    PR-URL: #42129
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Mesteery authored and bengl committed Mar 20, 2022
    Copy the full SHA
    7fc4b9f View commit details
    Browse the repository at this point in the history
  6. crypto: fix fingerprint string size calculation

    The function generating fingerprint strings never accesses more than
    EVP_MAX_MD_SIZE * 3 characters, including the terminating '\0'.
    
    PR-URL: #42175
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and bengl committed Mar 20, 2022
    Copy the full SHA
    1d0468f View commit details
    Browse the repository at this point in the history
  7. build: use ccache in make-v8.sh on ppc64le and s390x

    If `ccache` is available, use it during V8 builds on ppc64le and s390x.
    Only create the `gcc` and `g++` shims if necessary.
    
    PR-URL: #42204
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    richardlau authored and bengl committed Mar 20, 2022
    Copy the full SHA
    f27bcec View commit details
    Browse the repository at this point in the history
  8. url: trim leading and trailing C0 control chars

    Emulate the WHATWHG URL parse behavior of trimming leading and trailing
    C0 control characters. This moves url.parse() slightly closer to
    WHATWHG URL behavior. The current behavior is possibly insecure for some
    uses. (The url.parse() API is marked as Legacy and the documentation
    specifically says it has known bugs and insecure behaviors. Still this
    change makes a lot of sense.)
    
    This issue was reported by P0cas. https://github.com/P0cas
    
    PR-URL: #42196
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Trott authored and bengl committed Mar 20, 2022
    Copy the full SHA
    b89f4d5 View commit details
    Browse the repository at this point in the history
  9. string_decoder: fix crash when calling __proto__.write()

    This makes the function throw an exception from JS instead of crashing.
    
    Fixes: #41949
    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    
    PR-URL: #42062
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    RaisinTen authored and bengl committed Mar 20, 2022
    Copy the full SHA
    3492a0e View commit details
    Browse the repository at this point in the history
  10. doc: remove refs to old OpenSSL list-* commands

    The last release line that did not support the new openssl list command
    was OpenSSL 1.1.0, which reached its end-of-life status years ago.
    
    PR-URL: #42235
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and bengl committed Mar 20, 2022
    Copy the full SHA
    f3c6c00 View commit details
    Browse the repository at this point in the history
  11. deps: upgrade npm to 8.5.3

    PR-URL: #42205
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    npm-robot authored and bengl committed Mar 20, 2022
    Copy the full SHA
    70c0758 View commit details
    Browse the repository at this point in the history
  12. lib: fix AsyncResource.bind not using 'this' from the caller by default

    PR-URL: #42177
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
    Reviewed-By: Bryan English <bryan@bryanenglish.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    rochdev authored and bengl committed Mar 20, 2022
    Copy the full SHA
    69a3792 View commit details
    Browse the repository at this point in the history
  13. doc: deprecate string coercion in fs.write, fs.writeFileSync

    This also affects `fs.writeFile`, `fs.appendFile`, and
    `fs.appendFileSync`
    
    Refs: #41677
    
    PR-URL: #42149
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    LiviaMedeiros authored and bengl committed Mar 20, 2022
    Copy the full SHA
    2335467 View commit details
    Browse the repository at this point in the history
  14. src: use emplace_back instead of push_back

    PR-URL: #42159
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    yashLadha authored and bengl committed Mar 20, 2022
    Copy the full SHA
    9af9083 View commit details
    Browse the repository at this point in the history
  15. test: use global webcrypto for WPT tests

    PR-URL: #42236
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and bengl committed Mar 20, 2022
    Copy the full SHA
    a4aa9eb View commit details
    Browse the repository at this point in the history
  16. src,crypto: avoid tristate Maybe<bool> in ExportJWKEcKey()

    The function currently uses the return value to convey whether an
    exception was thrown while it was running by using either Just(true) or
    Nothing<bool>(). Unfortunately, Maybe<bool> also has a third state -
    Just(false), which doesn't make any sense here. So this change avoids
    the possibility of a tristate return value by making use of Maybe<void>
    which only has two valid states - JustVoid() / Nothing<void>(), which
    fits right in.
    
    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    
    PR-URL: #42223
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    RaisinTen authored and bengl committed Mar 20, 2022
    Copy the full SHA
    58763d7 View commit details
    Browse the repository at this point in the history
  17. debugger: correct typo in inspect_repl.js

    PR-URL: #42267
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    cola119 authored and bengl committed Mar 20, 2022
    Copy the full SHA
    3b55946 View commit details
    Browse the repository at this point in the history
  18. deps: update undici to 4.15.1

    This also adds a script to automate the update and includes the sources
    included in the npm tarball.
    
    PR-URL: #42246
    Fixes: #42199
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    targos authored and bengl committed Mar 20, 2022
    Copy the full SHA
    b60262e View commit details
    Browse the repository at this point in the history
  19. build: rename tools workflow and add undici to it

    The workflow already updates Corepack, which is a `deps`, not a `tool`.
    Add subsystem and label variables to the matrix to better control the
    automated pull requests and add undici to the updated deps.
    
    PR-URL: #42246
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    targos authored and bengl committed Mar 20, 2022
    Copy the full SHA
    1796f03 View commit details
    Browse the repository at this point in the history
  20. doc: remove outdated timeout.unref content

    resolve: #42239
    
    PR-URL: #42241
    Fixes: #42239
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    meixg authored and bengl committed Mar 20, 2022
    Copy the full SHA
    701dc14 View commit details
    Browse the repository at this point in the history
  21. http2: fix potential integer overflow

    Fix report from coverity on potential integer overflow
    in http2.
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #42248
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    mhdawson authored and bengl committed Mar 20, 2022
    Copy the full SHA
    88dee3c View commit details
    Browse the repository at this point in the history
  22. esm: add runtime warning for specifier resolution flag

    PR-URL: #42252
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    GeoffreyBooth authored and bengl committed Mar 20, 2022
    Copy the full SHA
    4829a10 View commit details
    Browse the repository at this point in the history
  23. src: perform minor cleanups on zlib code

    - Use `final` to indicate the classes that we actually
      instantiate
    - Properly use `const` (and the necessary associated `const_cast`
      for zlib because we don’t define `ZLIB_CONST` and allow shared
      builds)
    - Store the JS callback in an internal field rather than a `Global`
      (which improves memory leak debugging capabilities, removes
      a potential future memory leak footgun, and aligns the code
      with the rest of the codebase more closely)
    - Other minor C++ cleanup
    
    PR-URL: #42247
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax authored and bengl committed Mar 20, 2022
    Copy the full SHA
    d06e92d View commit details
    Browse the repository at this point in the history
  24. deps: V8: cherry-pick c6f6626deb14

    Original commit message:
    
        [riscv64] Fix segmentation fault of webpack-make from cockpit
    
        issue: riscv-collab/v8#520
    
        Change-Id: I7fe298ad16a2f599805929db0f084a81c4eb7f7a
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3503170
        Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
        Reviewed-by: ji qiu <qiuji@iscas.ac.cn>
        Reviewed-by: Yahan Lu <yahan@iscas.ac.cn>
        Commit-Queue: Yahan Lu <yahan@iscas.ac.cn>
        Cr-Commit-Position: refs/heads/main@{#79376}
    
    Refs: v8/v8@c6f6626
    
    PR-URL: #42240
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    luyahan authored and bengl committed Mar 20, 2022
    Copy the full SHA
    063ff08 View commit details
    Browse the repository at this point in the history
  25. src: remove redundant buffer size check

    This condition is already checked by the CHECK_BUFLEN_IN_RANGE macro,
    so if it was true here, that would contradict the previous check.
    
    PR-URL: #42257
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and bengl committed Mar 20, 2022
    Copy the full SHA
    e43aa30 View commit details
    Browse the repository at this point in the history
  26. test: add test case for reverted 17.7 regression

    Refs: #42279
    
    PR-URL: #42283
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and bengl committed Mar 20, 2022
    Copy the full SHA
    94e5eaa View commit details
    Browse the repository at this point in the history
  27. url: preserve null char in WHATWG URL errors

    A null character in the middle of an invalid URL was resulting in an
    error message that truncated the input string. This preserves the entire
    input string in the error message.
    
    Refs: #39592
    
    PR-URL: #42263
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and bengl committed Mar 20, 2022
    Copy the full SHA
    fe01940 View commit details
    Browse the repository at this point in the history
  28. src: include internal/options in the snapshot

    This patch enables internal/options to be included in the snapshot,
    so that when lazy loading the run time options, the modules only
    need to make sure that the options are queried lazily and do not
    have to lazy load the internal/options module together. We can
    still guarantee that no run time options are serialized into the
    state-independent bootstrap snapshot with the assertion inside
    GetCLIOptions().
    
    PR-URL: #42203
    Refs: #37476
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    joyeecheung authored and bengl committed Mar 20, 2022
    Copy the full SHA
    9fc4b9b View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2022

  1. meta: update AUTHORS

    PR-URL: #42317
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    nodejs-github-bot authored and bengl committed Mar 21, 2022
    Copy the full SHA
    e7b8d83 View commit details
    Browse the repository at this point in the history
  2. deps: cares: cherry-pick b5a3d96

    Original commit message:
    
    Asterisks should be allowed in host validation as CNAMEs may reference
    wildcard domains
    
    CloudFlare appears to use this logic in CNAMEs as per
    #42171
    
    Fixes: c-ares/c-ares#457
    Fix By: Brad House (@bradh352)
    
    PR-URL: #42216
    Fixes: #42171
    Fixes: #457
    Refs: c-ares/c-ares#457
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    bradh352 authored and bengl committed Mar 21, 2022
    Copy the full SHA
    f2178fc View commit details
    Browse the repository at this point in the history
  3. doc: improve pipe description

    I spent hours trying to make it work only to
    learn that it's not supported in node anymore,
    so I thought I'd save other people the time in the future.
    
    https://groups.google.com/g/nodejs/c/SxNKLclbM5k?pli=1
    
    PR-URL: #42295
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    mifi authored and bengl committed Mar 21, 2022
    Copy the full SHA
    8b99099 View commit details
    Browse the repository at this point in the history
  4. doc: clarify the meaning of legacy status

    Fixes: #42230
    Fixes: #42232
    
    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    
    PR-URL: #42269
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    RaisinTen authored and bengl committed Mar 21, 2022
    Copy the full SHA
    72dd500 View commit details
    Browse the repository at this point in the history
  5. tools: update eslint to 8.11.0

    PR-URL: #42318
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    nodejs-github-bot authored and bengl committed Mar 21, 2022
    Copy the full SHA
    eb0e1a1 View commit details
    Browse the repository at this point in the history
  6. src: check return value of HMAC_Final

    PR-URL: #42303
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    tniessen authored and bengl committed Mar 21, 2022
    Copy the full SHA
    08e2d8a View commit details
    Browse the repository at this point in the history
  7. esm: improve typings and code coverage

    PR-URL: #42305
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    bmeck authored and bengl committed Mar 21, 2022
    Copy the full SHA
    e17db8f View commit details
    Browse the repository at this point in the history
  8. src: avoid returning invalid value from hex2bin

    If the input is not a valid hexadecimal digit, hex2bin should not return
    an invalid value, which is not handled correctly by the caller, which is
    the PercentDecode function. However, PercentDecode only ever calls the
    hex2bin function with valid hexadecimal digits, so mark the code path
    that previously returned an invalid value for non-digits as UNREACHABLE.
    
    PR-URL: #42307
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and bengl committed Mar 21, 2022
    Copy the full SHA
    9500e58 View commit details
    Browse the repository at this point in the history
  9. src: simplify bound check in ParseArrayIndex

    PR-URL: #42306
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and bengl committed Mar 21, 2022
    Copy the full SHA
    8b84e68 View commit details
    Browse the repository at this point in the history
  10. tools: update lint-md-dependencies to rollup@2.70.0 unified@10.1.2

    PR-URL: #42316
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Joe Sepi <sepi@joesepi.com>
    nodejs-github-bot authored and bengl committed Mar 21, 2022
    Copy the full SHA
    30ea188 View commit details
    Browse the repository at this point in the history
  11. tools: update doc to highlight.js@11.5.0 unified@10.1.2

    PR-URL: #42315
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Joe Sepi <sepi@joesepi.com>
    nodejs-github-bot authored and bengl committed Mar 21, 2022
    Copy the full SHA
    b7a4b4b View commit details
    Browse the repository at this point in the history
  12. src: check EC_POINT_get_affine_coordinates result

    PR-URL: #42304
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    tniessen authored and bengl committed Mar 21, 2022
    Copy the full SHA
    846b074 View commit details
    Browse the repository at this point in the history
  13. src: fix coverity warnings in node_file.cc

    Fix two warnings about a useless call and not checking
    a return value.
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #42272
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    mhdawson authored and bengl committed Mar 21, 2022
    Copy the full SHA
    21198c1 View commit details
    Browse the repository at this point in the history
  14. test: improve _http_outgoing coverage

    PR-URL: #42213
    Refs: https://coverage.nodejs.org/coverage-29bb2bb57d2a993e/lib/_http_outgoing.js.html
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    kuriyosh authored and bengl committed Mar 21, 2022
    Copy the full SHA
    4941791 View commit details
    Browse the repository at this point in the history
  15. test: improve _http_incoming.js coverage

    PR-URL: #42211
    Refs: https://coverage.nodejs.org/coverage-010cb714161102de/lib/_http_incoming.js.html
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    kuriyosh authored and bengl committed Mar 21, 2022
    Copy the full SHA
    dfdce7c View commit details
    Browse the repository at this point in the history
  16. doc: clarify path search in child_process.spawn

    The documentation about command lookup could be more clear and note
    differences between Windows and Linux/OSX.
    Current text gives the impression that if one passes `options.env`
    without `PATH`, the path search will fall back on `process.env.PATH`.
    In reality, passing environment without `PATH` to `execvp` causes it
    to look for the binary only in `/usr/bin:/bin`.
    Also Windows behaves different and more in line with the current
    documentation text.
    
    PR-URL: #41418
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    zobo authored and bengl committed Mar 21, 2022
    Copy the full SHA
    96dc591 View commit details
    Browse the repository at this point in the history
  17. doc: fix async iterable pipeline signal examples

    Fix the pipeline examples to show that async generators receive
    an AbortSignal wrapped in an object.
    
    PR-URL: #42258
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tilgovi authored and bengl committed Mar 21, 2022
    Copy the full SHA
    fd7e4ab View commit details
    Browse the repository at this point in the history
  18. lib: refactor to use primordials in lib/assert.js

    PR-URL: #41702
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    marsonya authored and bengl committed Mar 21, 2022
    Copy the full SHA
    1fe0b69 View commit details
    Browse the repository at this point in the history
  19. esm: make extension-less errors in type:module actionable

    PR-URL: #42301
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    bmeck authored and bengl committed Mar 21, 2022
    Copy the full SHA
    e55283b View commit details
    Browse the repository at this point in the history
  20. doc: update base branch name for nodejs/nodejs.org

    PR-URL: #42355
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    danielleadams authored and bengl committed Mar 21, 2022
    Copy the full SHA
    e7e8eb9 View commit details
    Browse the repository at this point in the history
  21. doc: add @ShogunPanda to collaborators

    PR-URL: #42362
    Fixes: #42245
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    ShogunPanda authored and bengl committed Mar 21, 2022
    Copy the full SHA
    3bd0078 View commit details
    Browse the repository at this point in the history
  22. stream: do cleanup when iterator is destroyed

    PR-URL: #42320
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    KhooHaoYit authored and bengl committed Mar 21, 2022
    Copy the full SHA
    5367002 View commit details
    Browse the repository at this point in the history
  23. doc: revise async_hooks docs

    The only significant change is to replace AsyncHooks with `AsyncHook`.
    
    PR-URL: #42337
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Trott authored and bengl committed Mar 21, 2022
    Copy the full SHA
    46d3d23 View commit details
    Browse the repository at this point in the history
  24. doc: remove unneeded lint disable comment

    PR-URL: #42374
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Trott authored and bengl committed Mar 21, 2022
    Copy the full SHA
    6c265e7 View commit details
    Browse the repository at this point in the history
  25. doc: fix Embedder's Guide link to V8 official docs

    PR-URL: #42373
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    aroyan authored and bengl committed Mar 21, 2022
    Copy the full SHA
    a5e42f0 View commit details
    Browse the repository at this point in the history
  26. test: improve https_renew_cert.sh script

    - To avoid unnecessarily large diffs, only generate a new private key
      if necessary. Otherwise, reuse the existing private key and only
      issue a new certificate.
    - Remove an unnecessary conversion step using openssl rsa and the
      intermediate rsa.pem and csr.pem files.
    - Extend the certificate validity from 1 year to 10 years.
    - Show a text representation of the issued certificate upon completion
      such that the user can verify the validity.
    - Make the script executable.
    - Use "#!/usr/bin/env bash" instead of "#!/bin/bash".
    - Allow the script to be called from any directory.
    
    Refs: #42342
    Refs: #37990
    
    PR-URL: #42343
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    tniessen authored and bengl committed Mar 21, 2022
    Copy the full SHA
    b82bac0 View commit details
    Browse the repository at this point in the history
  27. worker: do not send message if port is closing

    Fixes: #42296
    
    PR-URL: #42357
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Trott authored and bengl committed Mar 21, 2022
    Copy the full SHA
    229fb40 View commit details
    Browse the repository at this point in the history
  28. http: trace http client by perf_hooks

    PR-URL: #42345
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
    theanarkh authored and bengl committed Mar 21, 2022
    Copy the full SHA
    da42ffb View commit details
    Browse the repository at this point in the history
  29. doc: document goal to have examples

    As discussed in next-10 mini-summit on documentation
    see minutes where next steps were discussed -
    https://github.com/nodejs/next-10/blob/main/meetings/2022-02-16.md
    and minutes from summit -
    https://github.com/nodejs/next-10/blob/main/meetings/2022-02-16.md
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #42274
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    mhdawson authored and bengl committed Mar 21, 2022
    Copy the full SHA
    78b858d View commit details
    Browse the repository at this point in the history
  30. src: convert hex2bin() into a regular function

    No need to write hex2bin() as a function template because it's only
    called with a char parameter.
    
    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    
    PR-URL: #42321
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    RaisinTen authored and bengl committed Mar 21, 2022
    Copy the full SHA
    e960424 View commit details
    Browse the repository at this point in the history
  31. test: give slow tests more time on Rasberry PIs

    Refs: #42379
    
    A number of tests have been failing internmittently
    on the Rasberry PIs with timeouts since the update
    to OpenSSL 3.0. Give them more time.
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #42380
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    mhdawson authored and bengl committed Mar 21, 2022
    Copy the full SHA
    d9a5c2b View commit details
    Browse the repository at this point in the history
  32. doc: update instructions for openssl updates

    Update to reflect additional PRs needed as some
    branches now use OpenSSL 3.x
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #42353
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    mhdawson authored and bengl committed Mar 21, 2022
    Copy the full SHA
    04a7c00 View commit details
    Browse the repository at this point in the history
  33. doc: add that chacha20-poly1305 is IETF version

    PR-URL: #42370
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    tniessen authored and bengl committed Mar 21, 2022
    Copy the full SHA
    88d3401 View commit details
    Browse the repository at this point in the history
  34. deps: upgrade npm to 8.5.5

    PR-URL: #42382
    Reviewed-By: Ruy Adorno <ruyadorno@github.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    npm-robot authored and bengl committed Mar 21, 2022
    Copy the full SHA
    84fd6e5 View commit details
    Browse the repository at this point in the history
  35. test,crypto: add and update empty passphrase regression tests

    Refs: openssl/openssl#17507
    Refs: #41428
    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    
    PR-URL: #42319
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    RaisinTen authored and bengl committed Mar 21, 2022
    Copy the full SHA
    26d4a2d View commit details
    Browse the repository at this point in the history
  36. doc: improve README.md usability

    * The logo takes a lot of room doesn't add information.
    * Make Node.js a top-level header and Table of Contents a  second-level
      header.
    
    This looks better, improve semantics, makes the README.md more usable in
    its raw form, and aligns us with README.md practices in other projects
    like TypeScript and Deno.
    
    PR-URL: #42378
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Trott authored and bengl committed Mar 21, 2022
    Copy the full SHA
    db83c4d View commit details
    Browse the repository at this point in the history
  37. crypto: fix auth tag length error when mode != GCM

    PR-URL: #42383
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and bengl committed Mar 21, 2022
    Copy the full SHA
    f48c3ba View commit details
    Browse the repository at this point in the history
  38. tools: update lint-md-dependencies to rollup@2.70.1

    PR-URL: #42403
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    nodejs-github-bot authored and bengl committed Mar 21, 2022
    Copy the full SHA
    38e7681 View commit details
    Browse the repository at this point in the history
  39. meta: update AUTHORS

    PR-URL: #42404
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    nodejs-github-bot authored and bengl committed Mar 21, 2022
    Copy the full SHA
    1c87ce6 View commit details
    Browse the repository at this point in the history
  40. tools: make update-undici script executable

    PR-URL: #42406
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    targos authored and bengl committed Mar 21, 2022
    Copy the full SHA
    4fd2aff View commit details
    Browse the repository at this point in the history
  41. doc: fix version history for net.Socket and net.Server

    Refs: #41310
    
    Backport-PR-URL: #42270
    PR-URL: #42268
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    aduh95 authored and bengl committed Mar 21, 2022
    Copy the full SHA
    fd51e78 View commit details
    Browse the repository at this point in the history
  42. 2022-03-22, Version 17.8.0 (Current)

    Notable changes:
    
    doc:
      * add @ShogunPanda to collaborators (Shogun) #42362
      * deprecate string coercion in `fs.write`, `fs.writeFileSync` (Livia Medeiros) #42149
    http:
      * (SEMVER-MINOR) trace http client by perf_hooks (theanarkh) #42345
    deps:
      * upgrade npm to 8.5.5 (npm team) #42382
      * update undici to 4.15.1 (Michaël Zasso) #42246
    
    PR-URL: #42425
    bengl committed Mar 21, 2022
    Copy the full SHA
    123661e View commit details
    Browse the repository at this point in the history