Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14.x backport] child_process: queue pending messages #42840

Closed
wants to merge 1 commit into from
Closed

[v14.x backport] child_process: queue pending messages #42840

wants to merge 1 commit into from

Conversation

ErickWendel
Copy link
Member

Backport of #41221

It fixes the problem of the child process not receiving messages.

Fixes: #41134

@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run. v14.x labels Apr 23, 2022
@ErickWendel
child_process: queue pending messages
1046464 
It fixes the problem of the child process not receiving messages.

Fixes: nodejs#41134
@ErickWendel ErickWendel marked this pull request as ready for review April 23, 2022 16:55
@noahnu noahnu mentioned this pull request Apr 24, 2022
Merged
@aduh95 aduh95 mentioned this pull request Apr 28, 2022
Merged
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 28, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 28, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43754/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 28, 2022 •
edited by juanarbol

CI: https://ci.nodejs.org/job/node-test-pull-request/43758/ (:heavy_check_mark:)

juanarbol pushed a commit that referenced this pull request May 1, 2022
@ErickWendel @juanarbol
child_process: queue pending messages
4203d13 
It fixes the problem of the child process not receiving messages.

Fixes: #41134

PR-URL: #41221
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Backport-PR-URL: #42840
@juanarbol
Copy link
Member

Landed in 4203d13 🎉

@juanarbol juanarbol closed this May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleadams danielleadams danielleadams approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ErickWendel @nodejs-github-bot @juanarbol @danielleadams @aduh95