Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: revert "validate ipv4 part length" #42940

Merged
merged 2 commits into from May 5, 2022
Merged

url: revert "validate ipv4 part length" #42940

merged 2 commits into from May 5, 2022

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented May 2, 2022

This reverts commit 87d0d7a.

Refs: #42915 (comment)

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels May 2, 2022
targos
targos approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we usually keep the revert message created by Git?

@aduh95
Copy link
Contributor Author

aduh95 commented May 2, 2022

Don't we usually keep the revert message created by Git?

Looking at git log --grep='This reverts commit', there are two schools of thought on the question. Looking at our commit message guidelines, it doesn't say revert commits should be treated differently, so I'm going to leave the message as is, whoever lands this can choose a different commit message.

@targos targos added the dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. label May 2, 2022
@addaleax
Copy link
Member

addaleax commented May 2, 2022

Looking at our commit message guidelines, it doesn't say revert commits should be treated differently

Our release tooling does have special treatment for the standard git revert message format. I’d rather edit our commit message guidelines to reflect that than ignore it 🙂 e.g. https://github.com/nodejs/node/blob/1d8a320a04d75b2143be0bc97b10dfcd9e64defa/doc/changelogs/CHANGELOG_V16.md#commits-3 contains

  • [6af3e34b6b] - Revert "async_hooks: merge resource_symbol with owner_symbol" (Darshan Sen) #40741

@sepehrst
Copy link

sepehrst commented May 2, 2022

Since this is a revert, is it reasonable to fast-track so it can be included in the 3rd May builds?

@aduh95
Copy link
Contributor Author

aduh95 commented May 2, 2022

dont-land-on-v18.x

This PR and the on it reverts has the https://github.com/nodejs/node/labels/dont-land-on-v18.x, so none will be included on May 3rd release anyway :)

@nodejs nodejs deleted a comment from amusaber950 May 2, 2022
@nodejs nodejs deleted a comment from amusaber950 May 2, 2022
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 4, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 4, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43881/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43885/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 5, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 5, 2022
@nodejs-github-bot nodejs-github-bot merged commit a3ff4bf into nodejs:master May 5, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in a3ff4bf

@aduh95 aduh95 deleted the revert-url-ipv4-fix branch May 5, 2022 11:49
This was referenced May 12, 2022
Open
Closed
Open
@F3n67u F3n67u mentioned this pull request Jun 4, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jun 11, 2022
@aduh95 @danielleadams
url: revert "validate ipv4 part length"
8fc42d3 
This reverts commit 87d0d7a.

Refs: #42915

PR-URL: #42940
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Jun 11, 2022
Merged
@RafaelGSS RafaelGSS mentioned this pull request Oct 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@targos targos targos approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@aduh95 @addaleax @sepehrst @nodejs-github-bot @Trott @targos @VoltrexKeyva @richardlau