Commits on May 26, 2022

1. src,inspector: fix empty MaybeLocal crash …

   Return early when the Inspector StringView to V8 String conversion fails
   and returns an empty MaybeLocal instead of running the invalid
   ToLocalChecked() assertion.
   
   Fixes: nodejs#42407
   Signed-off-by: Darshan Sen <raisinten@gmail.com>
   
   PR-URL: nodejs#42409
   Reviewed-By: Richard Lau <rlau@redhat.com>
   Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
   Reviewed-By: Anna Henningsen <anna@addaleax.net>
   Reviewed-By: Tobias Nießen <tniessen@tnie.de>
   Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
   Reviewed-By: James M Snell <jasnell@gmail.com>

   

   RaisinTen authored and Roy Van Liew committed May 26, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 97c442a
   • Browse repository at this point

   Copy the full SHA

   97c442a View commit details

   Browse the repository at this point in the history

2. test: delete test/pummel/test-repl-empty-maybelocal-crash.js …

   It was disconnecting the runners from the CI server. Not worth having a
   resource-intensive test for this kind of an edge cases.
   
   Fixes: nodejs#42719
   Signed-off-by: Darshan Sen <raisinten@gmail.com>
   PR-URL: nodejs#42720
   Fixes: nodejs#42719
   Reviewed-By: James M Snell <jasnell@gmail.com>
   Reviewed-By: Michaël Zasso <targos@protonmail.com>
   Reviewed-By: Richard Lau <rlau@redhat.com>
   Reviewed-By: Beth Griggs <bgriggs@redhat.com>
   Reviewed-By: Stewart X Addison <sxa@redhat.com>
   Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

   

   RaisinTen authored and Roy Van Liew committed May 26, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for bbd5fe6
   • Browse repository at this point

   Copy the full SHA

   bbd5fe6 View commit details

   Browse the repository at this point in the history