v18.3.0 proposal #43266
Merged
v18.3.0 proposal #43266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #42740 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: #42740 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Original commit message:
[testrunner] delete ancient junit compatible format support
Testrunner has ancient support for JUnit compatible XML output.
This CL removes this old feature.
R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org
CC=machenbach@chromium.org
Bug: v8:8728
Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0
Reviewed-on: https://chromium-review.googlesource.com/c/1430065
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Tamer Tas <tmrts@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59045}
Refs: v8/v8@bd019bd
PR-URL: #32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Co-Authored-By: Richard Lau <rlau@redhat.com>
This should be semver-patch since actual invocation is version conditional. PR-URL: #32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #35415 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> deps: patch for v8 on windows PR-URL: #40010 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> deps: patch v8 for vs2019 in std17 PR-URL: #40060 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> deps: workaround debug link error on Windows PR-URL: #38807 Refs: #38788 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ash Cripps <acripps@redhat.com>
`handler-outside-simulator.cc` uses inline assembly, which is not supported by MSVC. PR-URL: #40488 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
We are not ready to migrate yet. Refs: nodejs/node-v8#214 PR-URL: #40907 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: #42375 PR-URL: #42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Remove call to `memfd_create`. The function that references it is only used for V8 testing. PR-URL: #42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Create an unused deopt kind to replace `DeoptimizeKind::kSoft`, which was removed. This ensures that the layout of IsolateData doesn't change. Refs: v8/v8@1ff685d PR-URL: #42740 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: #42740 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
V8's test runner now requires Python 3. Use the Python binary we detected that is used elsewhere in the Makefile. PR-URL: #42740 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Refs: v8/v8@10.2.154.2...10.2.154.4 PR-URL: #43067 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
According to the chrome trace event format document, works that are performed on one single thread should be traced with sync duration events. In this way, these events can be grouped under one thread and the trace event viewer can estimate the CPU usage of that thread. PR-URL: #42977 Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: #43037 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Since V8 code cache encodes indices to the read-only space it is safer to make sure that the code cache is generated in the same heap used to generate the embdded snapshot. This patch merges the code cache builder into the snapshot builder and makes the code cache part of node::SnapshotData that is deserialized into the native module loader during bootstrap. PR-URL: #43023 Fixes: #31074 Refs: #35711 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This rather mysterious operator is only used once and can easily be replaced with ssl_ctx(). PR-URL: #43121 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This change allows passing objects as "named parameters": - `fs.write(fd, buffer[, options], callback)` - `fs.writeSync(fd, buffer[, options])` - `filehandle.write(buffer[, options])` Fixes: #41666 PR-URL: #42601 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #43114 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
PR-URL: #43127 Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Coverity issues a warning about `value_before_reset == ca`, where value_before_reset is a pointer that may not be valid. While comparing the pointer itself should still work, we should really be using smart pointers here so that this particular check can be simplified without running into a memory leak. Refactor SSL_CTX_get_issuer to return a smart pointer and update the call sites accordingly. Note that we might have to change that in the future once we improve error handling throughout crypto/tls. Refs: #37990 PR-URL: #43117 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
PR-URL: #43061 Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
PR-URL: #43144 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #43011 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Worker.parent_port_ can be released before the exit event of Worker. The parent_port_ is not owned by `node::worker::Worker`, thus the reference to it is not always valid, and accessing it at exit crashes the process. As the Worker.parent_port_ is only used in the memory info tracking, it can be safely removed. PR-URL: #43123 Fixes: #43122 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #43143 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
PR-URL: #43152 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
|
@ruyadorno Changed it. @targos If you could double-check that I've got the semver status of the V8 commits correctly, that would be great! 😄 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
I don't have much luck against the flaky CI. FYI that release shipped a very important feature for |
richardlau
approved these changes
Jun 1, 2022
ruyadorno
approved these changes
Jun 1, 2022
BethGriggs
approved these changes
Jun 1, 2022
PR-URL: #43262 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Notable changes: * deps: update undici to 5.4.0 (Node.js GitHub Bot) #43262 * (SEMVER-MINOR) util: add parseArgs module (Benjamin Coe) #42675 * (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397 * deps: upgrade npm to 8.11.0 (npm team) #43210 * deps: patch V8 to 10.2.154.4 (Michaël Zasso) #43067 * (SEMVER-MINOR) deps: update V8 to 10.2.154.2 (Michaël Zasso) #42740 * (SEMVER-MINOR) fs: make params in writing methods optional (LiviaMedeiros) #42601 * (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397 * (SEMVER-MINOR) net: add ability to reset a tcp socket (pupilTong) #43112 * (SEMVER-MINOR) Revert "build: make x86 Windows support temporarily experimental" (Michaël Zasso) [#42740](#42740) * This means 32-bit Windows binaries are back with this release. PR-URL: #43266
This comment was marked as outdated.
This comment was marked as outdated.
|
I've added #43262 as per @mcollina's request. New CI: https://ci.nodejs.org/job/node-test-pull-request/44307/ If all goes well, I'll promote this tonight. |
19 tasks
RafaelGSS
approved these changes
Jun 2, 2022
bengl
added a commit
that referenced
this pull request
Jun 2, 2022
Notable changes: * deps: update undici to 5.4.0 (Node.js GitHub Bot) #43262 * (SEMVER-MINOR) util: add parseArgs module (Benjamin Coe) #42675 * (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397 * deps: upgrade npm to 8.11.0 (npm team) #43210 * deps: patch V8 to 10.2.154.4 (Michaël Zasso) #43067 * (SEMVER-MINOR) deps: update V8 to 10.2.154.2 (Michaël Zasso) #42740 * (SEMVER-MINOR) fs: make params in writing methods optional (LiviaMedeiros) #42601 * (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397 * (SEMVER-MINOR) net: add ability to reset a tcp socket (pupilTong) #43112 * (SEMVER-MINOR) Revert "build: make x86 Windows support temporarily experimental" (Michaël Zasso) [#42740](#42740) * This means 32-bit Windows binaries are back with this release. PR-URL: #43266
bengl
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Jun 2, 2022
bengl
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Jun 2, 2022
Belated LGTM |
This was referenced Jun 3, 2022
italojs
pushed a commit
to italojs/node
that referenced
this pull request
Jun 6, 2022
Notable changes: * deps: update undici to 5.4.0 (Node.js GitHub Bot) nodejs#43262 * (SEMVER-MINOR) util: add parseArgs module (Benjamin Coe) nodejs#42675 * (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) nodejs#41397 * deps: upgrade npm to 8.11.0 (npm team) nodejs#43210 * deps: patch V8 to 10.2.154.4 (Michaël Zasso) nodejs#43067 * (SEMVER-MINOR) deps: update V8 to 10.2.154.2 (Michaël Zasso) nodejs#42740 * (SEMVER-MINOR) fs: make params in writing methods optional (LiviaMedeiros) nodejs#42601 * (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) nodejs#41397 * (SEMVER-MINOR) net: add ability to reset a tcp socket (pupilTong) nodejs#43112 * (SEMVER-MINOR) Revert "build: make x86 Windows support temporarily experimental" (Michaël Zasso) [nodejs#42740](nodejs#42740) * This means 32-bit Windows binaries are back with this release. PR-URL: nodejs#43266
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2022-05-31, Version 18.3.0 (Current), @bengl
Notable Changes
dc3b91f351] - deps: update undici to 5.4.0 (Node.js GitHub Bot) #43262d6cf409d78] - (SEMVER-MINOR) util: add parseArgs module (Benjamin Coe) #426759539cfa358] - (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #4139741fdc2617d] - deps: upgrade npm to 8.11.0 (npm team) #432100000654e47] - deps: patch V8 to 10.2.154.4 (Michaël Zasso) #43067b3c8e609fd] - (SEMVER-MINOR) deps: update V8 to 10.2.154.2 (Michaël Zasso) #427403e89b7336d] - (SEMVER-MINOR) fs: make params in writing methods optional (LiviaMedeiros) #426019539cfa358] - (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #413978f5b4570e5] - (SEMVER-MINOR) net: add ability to reset a tcp socket (pupilTong) #431125eff7b4a6a] - (SEMVER-MINOR) Revert "build: make x86 Windows support temporarily experimental" (Michaël Zasso) #42740Commits
Commits
aefc9dda9a] - benchmark: add node-error benchmark (RafaelGSS) #4307785d81a764f] - bootstrap: include code cache in the embedded snapshot (Joyee Cheung) #430235eff7b4a6a] - (SEMVER-MINOR) Revert "build: make x86 Windows support temporarily experimental" (Michaël Zasso) #42740d6634707c5] - (SEMVER-MINOR) build: run V8 tests with detected Python version (Richard Lau) #42740b8b5e6df67] - (SEMVER-MINOR) build: reset embedder string to "-node.0" (Michaël Zasso) #42740285ef30877] - console: fix console.dir crash on a revoked proxy (Daeyeon Jeong) #43100920d8c5300] - crypto: align webcrypto RSA key import/export with other implementations (Filip Skokan) #42816c76caadf2e] - debugger: throw a more useful error when the frame is missing (Kohei Ueno) #42776dc3b91f351] - deps: update undici to 5.4.0 (Node.js GitHub Bot) #4326235250bf2f6] - deps: regenerate OpenSSL archs files (Daniel Bevenius) #42973ecacc3a727] - deps: exclude linker scripts for windows builds (Daniel Bevenius) #4297341fdc2617d] - deps: upgrade npm to 8.11.0 (npm team) #4321087b248e27e] - deps: update undici to 5.3.0 (Node.js GitHub Bot) #43197d42de132a7] - deps: upgrade npm to 8.10.0 (npm team) #430610000654e47] - deps: patch V8 to 10.2.154.4 (Michaël Zasso) #43067742ffefb44] - (SEMVER-MINOR) deps: make V8 10.2 ABI-compatible with 10.1 (Michaël Zasso) #42740c626a533c7] - deps: make V8 compilable with older glibc (Michaël Zasso) #4265776546b12a2] - deps: V8: fix v8-cppgc.h for MSVC (Jiawen Geng) #4265745e1fd4473] - deps: silence V8's warning on CompileFunction (Michaël Zasso) #409072130891a9a] - (SEMVER-MINOR) deps: disable trap handler for Windows cross-compiler (Michaël Zasso) #40488e678b6c63d] - deps: fix V8 build issue with inline methods (Jiawen Geng) #38807f83323f304] - deps: V8: forward declaration ofRtl*FunctionTable(Refael Ackermann) #321164be7584ca6] - deps: V8: un-cherry-pick bd019bd (Refael Ackermann) #32116b3c8e609fd] - (SEMVER-MINOR) deps: update V8 to 10.2.154.2 (Michaël Zasso) #427400afdc3e9a8] - doc: use serial comma in errors docs (Tobias Nießen) #4324200989338b3] - doc: add note regarding%Array.prototype.concat%inprimordials.md(Antoine du Hamel) #43166badf72dd0a] - doc: use serial comma in worker_threads docs (Tobias Nießen) #43220776e746f0a] - doc: fix napi version for node_api_symbol_for (Danielle Adams) #4287876b46801f8] - doc: documentsignaloption forEventTarget#addEventListener(Antoine du Hamel) #431703082c75efd] - doc: make minor adjustments (LiviaMedeiros) #43175598c1f102e] - doc: use serial comma in dgram docs (Tobias Nießen) #43191b772c13a62] - doc: use serial comma in process docs (Tobias Nießen) #43179f90a3d7a54] - doc: improved parallel specification (mawaregetsuka) #4267971074eedef] - doc: improve callback params forfs.mkdir(Daeyeon Jeong) #430162b8b224077] - doc: remove outdated footnote (Python 2 --> 3 for V8 tests) (DeeDeeG) #43105945f228cf1] - doc: add release key for RafaelGSS (Rafael Gonzaga) #4313156fc712f93] - doc: use serial comma in assert docs (Tobias Nießen) #43154093a3cf2f1] - doc: fix errors in Performance hooks doc (OneNail) #431524d9f43a8a7] - doc: use serial comma in dns docs (Tobias Nießen) #431454e9393e32f] - doc: use ASCII apostrophes consistently (Tobias Nießen) #43114b3181851d7] - doc: add strategic initiative for shadow realm (Chengzhong Wu) #430376f48dfb499] - fs: add trailing commas (LiviaMedeiros) #431273e89b7336d] - (SEMVER-MINOR) fs: make params in writing methods optional (LiviaMedeiros) #426019539cfa358] - (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397b187060f76] - http2: set origin name correctly when servername is empty (ofirbarak) #42838a07f5f28f3] - http2: improve tests and docs (Daeyeon Jeong) #42858701d40496d] - lib: refactorvalidateInt32andvalidateUint32(mawaregetsuka) #4307109da76493a] - meta: update AUTHORS (Node.js GitHub Bot) #432311da6b7c32b] - meta: add mailmap entry for legendecas (Chengzhong Wu) #431561be254b24e] - meta: add mailmap entry for npm team (Luigi Pinca) #431437d8d9d625a] - meta: add mailmap entry for Morgan Roderick (Luigi Pinca) #431448f5b4570e5] - (SEMVER-MINOR) net: add ability to reset a tcp socket (pupilTong) #4311211c783fa63] - net: remoteAddress always undefined called before connected (OneNail) #430119c4e070567] - (SEMVER-MINOR) node-api: emit uncaught-exception on unhandled tsfn callbacks (Chengzhong Wu) #3651054d68b1afd] - perf_hooks: fix start_time of perf_hooks (theanarkh) #43069baa5d0005a] - src: refactor GetCipherValue and related functions (Tobias Nießen) #431716ee9fb14e4] - src: make SecureContext fields private (Tobias Nießen) #431731e2552ba6c] - src: reuse GetServerName (Tobias Nießen) #43168d8a14a2486] - src: fix static analysis warning and use smart ptr (Tobias Nießen) #4311772a767b7ca] - src: remove SecureContext::operator* (Tobias Nießen) #4312182fb037388] - src: move context snapshot index to SnapshotData (Joyee Cheung) #430239577878258] - src: replace TraceEventScope with sync events (Chengzhong Wu) #4297741b69e3cf4] - src,lib: migrate to console on context's extra binding (Chengzhong Wu) #431423e1ed1ee0c] - test: improve code coverage for inspector connection errors (Kohei Ueno) #42310d7ca2234dc] - test: use mustSucceed instead of mustCall with assert.ifError (MURAKAMI Masahiko) #431889cc5ce6a24] - test: improve readline/emitKeypressEvents.js coverage (OneNail) #42908447bbd0d66] - tls: fix convertALPNProtocols accepting ArrayBufferViews (LiviaMedeiros) #43211df691464aa] - tools: update lint-md-dependencies to rollup@2.75.1 (Node.js GitHub Bot) #43230d9fb25c936] - tools: refactor build-addons.js to ESM (Feng Yu) #430990efeceb4a6] - tools: update lint-md-dependencies to rollup@2.74.1 (Node.js GitHub Bot) #43172ed352a945c] - tools: update eslint to 8.16.0 (Node.js GitHub Bot) #431741183058908] - tools: refactor update-authors.js to ESM (Feng Yu) #430985228028962] - (SEMVER-MINOR) tools: update V8 gypfiles for 10.2 (Michaël Zasso) #42740d6cf409d78] - (SEMVER-MINOR) util: add parseArgs module (Benjamin Coe) #42675d91b489784] - worker: fix heap snapshot crash on exit (Chengzhong Wu) #43123