Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed http_server timeout logic for requestTimeout and headerTimeout #43354

Closed
wants to merge 1 commit into from
Closed

Fixed http_server timeout logic for requestTimeout and headerTimeout #43354

wants to merge 1 commit into from

Commits on Jun 9, 2022

  1. Fixed http_server timeout logic for requestTimeout and headerTimeout 

    According to the documentation and also logic, headersTimeout should be smaller or equal to requestTimeout. This fixes the logic handling this check.

Node could also clamp requestTimeout to headersTimeout if the latter is larger, but that's a design decision for a different person.

I suspect there might be other range issues like this, too.
    @emilfihlman
    emilfihlman committed Jun 9, 2022
    Copy the full SHA
    9efa532 View commit details
    Browse the repository at this point in the history