Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: allow EOVERFLOW errors in fs position tests #43510

Merged
merged 1 commit into from Jun 22, 2022
Merged

test: allow EOVERFLOW errors in fs position tests #43510

merged 1 commit into from Jun 22, 2022

Conversation

richardlau
Copy link
Member

Some platforms may return EOVERFLOW errors instead of EFBIG.

Refs: #42999
Refs: #43509
Refs: #36925 (comment)

@richardlau
test: allow EOVERFLOW errors in fs position tests
53c9322 
Some platforms may return `EOVERFLOW` errors instead of `EFBIG`.
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 20, 2022
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 20, 2022
@richardlau richardlau mentioned this pull request Jun 20, 2022
Closed
4 tasks
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 20, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44764/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44766/

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 20, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44771/

@github-actions github-actions bot mentioned this pull request Jun 21, 2022
Open
33 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44778/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44780/

@github-actions github-actions bot mentioned this pull request Jun 22, 2022
Open
35 tasks
@bnoordhuis
Copy link
Member

Libuv should probably handle this by remapping EOVERFLOW to EFBIG in file operations. This PR fixes the tests but it doesn't help node users.

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 22, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 22, 2022
@nodejs-github-bot nodejs-github-bot merged commit 3b8f3e6 into nodejs:main Jun 22, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 3b8f3e6

@richardlau richardlau deleted the eoverflow branch June 22, 2022 18:27
This was referenced Jun 23, 2022
Open
Open
F3n67u pushed a commit to F3n67u/node that referenced this pull request Jun 24, 2022
@richardlau @F3n67u
test: allow EOVERFLOW errors in fs position tests
2fd4622 
Some platforms may return `EOVERFLOW` errors instead of `EFBIG`.

PR-URL: nodejs#43510
Refs: nodejs#42999
Refs: nodejs#43509
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Jun 25, 2022
Open
Open
targos pushed a commit that referenced this pull request Jul 12, 2022
@richardlau @targos
test: allow EOVERFLOW errors in fs position tests
7ca58b8 
Some platforms may return `EOVERFLOW` errors instead of `EFBIG`.

PR-URL: #43510
Refs: #42999
Refs: #43509
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 20, 2022
@richardlau @targos
test: allow EOVERFLOW errors in fs position tests
8e72a2c 
Some platforms may return `EOVERFLOW` errors instead of `EFBIG`.

PR-URL: #43510
Refs: #42999
Refs: #43509
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@richardlau @targos
test: allow EOVERFLOW errors in fs position tests
7ce80d8 
Some platforms may return `EOVERFLOW` errors instead of `EFBIG`.

PR-URL: #43510
Refs: #42999
Refs: #43509
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@richardlau @guangwong
test: allow EOVERFLOW errors in fs position tests
8089011 
Some platforms may return `EOVERFLOW` errors instead of `EFBIG`.

PR-URL: nodejs/node#43510
Refs: nodejs/node#42999
Refs: nodejs/node#43509
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santigimeno santigimeno santigimeno approved these changes

@lpinca lpinca lpinca approved these changes

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@richardlau @nodejs-github-bot @bnoordhuis @santigimeno @lpinca @LiviaMedeiros