test: mark flaky tests on smartos #43596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
async_hooks
Closed
github-actions
bot
removed
the
request-ci
|
I don't have permission on the repo to approve, but I approve. |
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
tniessen
approved these changes
Jun 28, 2022
panva
approved these changes
Jun 28, 2022
bnoordhuis
approved these changes
Jun 28, 2022
There was a problem hiding this comment.
LGTM. Only question I have is if the increased timeout mentioned in #43457 (comment) won't mean the smartos bots are now slowest to finish. Because if that's the case I'd rather just disable testing on them altogether.
bnoordhuis
added
the
fast-track
|
Fast-track has been requested by @bnoordhuis. Please 👍 to approve. |
richardlau
approved these changes
Jun 28, 2022
RaisinTen
approved these changes
Jun 28, 2022
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ea99431 |
23 tasks
@bnoordhuis node-test-commit-aix takes 49 min, node-test-commit-smartos takes 47 min, node-test-commit-smartos is not the slowest.
|
mabaasit
pushed a commit
to mabaasit/node
that referenced
this pull request
Jul 6, 2022
PR-URL: nodejs#43596 Refs: nodejs#43457 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43596 Refs: nodejs/node#43457 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collect the tests that are flaky only on SmartOS between 06-22 and 06-28, and mark them as flaky in one go.
Collect from https://github.com/nodejs/reliability/issues.
Refs: #43457