[v14.x] src: fix IS_LTS and IS_RELEASE flags #43761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
approved these changes
Jul 10, 2022
BethGriggs
approved these changes
Jul 11, 2022
targos
approved these changes
Jul 11, 2022
RafaelGSS
approved these changes
Jul 11, 2022
ruyadorno
approved these changes
Jul 11, 2022
Clear the `NODE_VERSION_IS_RELEASE` flag and restore the `NODE_VERSION_IS_LTS` flag.
richardlau
force-pushed
the
v14.x-staging-flags
branch
from
aa688b9
to
14297d9
Compare
github-actions
bot
removed
the
request-ci
richardlau
added a commit
that referenced
this pull request
Jul 12, 2022
Clear the `NODE_VERSION_IS_RELEASE` flag and restore the `NODE_VERSION_IS_LTS` flag. PR-URL: #43761 Refs: https://github.com/nodejs/node/runs/7271286633?check_suite_focus=true Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ruy Adorno <ruyadorno@github.com>
|
Landed in de80707. |
This was referenced Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear the
NODE_VERSION_IS_RELEASEflag and restore theNODE_VERSION_IS_LTSflag.Refs: https://github.com/nodejs/node/runs/7271286633?check_suite_focus=true
cc @nodejs/releasers