Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: do not leak memory if buffer is too big #43938

Merged
merged 1 commit into from Jul 24, 2022
Merged

buffer: do not leak memory if buffer is too big #43938

merged 1 commit into from Jul 24, 2022

Commits on Jul 23, 2022

  1. buffer: do not leak memory if buffer is too big 

    A recent pull request changed this method to throw when the buffer was
too big, but this meant that the `free` finalizer would never get
called, leading to a memory leak.

A previous version of this diff included a test provoking this behavior
with `v8.serialize`, but it unfortunately kept triggering the OOM
killer, so it was removed.

Refs: nodejs#40243
    @kvakil
    kvakil committed Jul 23, 2022
    Copy the full SHA
    c949bf1 View commit details
    Browse the repository at this point in the history