Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src,lib: print prinstine source when source map source not found #44052

Closed
wants to merge 1 commit into from
Closed

src,lib: print prinstine source when source map source not found #44052

wants to merge 1 commit into from

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Jul 30, 2022 •
edited

Print unmapped source lines when the source map source is not found. Error stacks should be correctly mapped even when the source is absent.

Refs: #44019

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 30, 2022
@legendecas legendecas marked this pull request as ready for review July 30, 2022 08:36
@legendecas legendecas requested a review from bcoe August 1, 2022 15:36
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 4, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 4, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45829/

legendecas
legendecas commented Aug 4, 2022
View reviewed changes
lib/internal/source_map/prepare_stack_trace.js
Comment on lines +149 to +151
if (typeof source !== 'string') {
return;
}

This comment was marked as outdated.

Sign in to view

@legendecas
Copy link
Member Author

Landed in 0a2c910

@legendecas legendecas closed this Aug 6, 2022
@legendecas legendecas deleted the test-error-source branch August 6, 2022 11:57
legendecas added a commit that referenced this pull request Aug 6, 2022
@legendecas
src,lib: print prinstine source when source map source not found
0a2c910 
Print unmapped source lines when the source map source is not
found. Error stacks should be correctly mapped even when the
source is absent.

PR-URL: #44052
Refs: #44019
Reviewed-By: Ben Coe <bencoe@gmail.com>
danielleadams pushed a commit that referenced this pull request Aug 16, 2022
@legendecas @danielleadams
src,lib: print prinstine source when source map source not found
63b5c49 
Print unmapped source lines when the source map source is not
found. Error stacks should be correctly mapped even when the
source is absent.

PR-URL: #44052
Refs: #44019
Reviewed-By: Ben Coe <bencoe@gmail.com>
@danielleadams danielleadams mentioned this pull request Aug 16, 2022
Closed
ruyadorno pushed a commit that referenced this pull request Aug 23, 2022
@legendecas @ruyadorno
src,lib: print prinstine source when source map source not found
ee6412a 
Print unmapped source lines when the source map source is not
found. Error stacks should be correctly mapped even when the
source is absent.

PR-URL: #44052
Refs: #44019
Reviewed-By: Ben Coe <bencoe@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Aug 23, 2022
Merged
Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
@legendecas @Fyko
src,lib: print prinstine source when source map source not found
fb180fb 
Print unmapped source lines when the source map source is not
found. Error stacks should be correctly mapped even when the
source is absent.

PR-URL: nodejs#44052
Refs: nodejs#44019
Reviewed-By: Ben Coe <bencoe@gmail.com>
@juanarbol
Copy link
Member

This depends on #43875 to be landed in v16.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@legendecas @nodejs-github-bot @juanarbol @bcoe