Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: mark --import as experimental #44067

Merged
merged 1 commit into from Jul 31, 2022
Merged

doc: mark --import as experimental #44067

merged 1 commit into from Jul 31, 2022

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Jul 31, 2022

No description provided.

@nodejs-github-bot nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels Jul 31, 2022
@MoLow MoLow mentioned this pull request Jul 31, 2022
Merged
1 task
@MoLow MoLow added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 31, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @MoLow. Please 👍 to approve.

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 31, 2022
@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 31, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 31, 2022
@nodejs-github-bot nodejs-github-bot merged commit 77cb88b into nodejs:main Jul 31, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 77cb88b

@MoLow MoLow deleted the mark-import-as-experimental branch July 31, 2022 10:16
@danielleadams
Copy link
Member

Adding backport-blocked since the original docs have not landed yet (#43942)

@danielleadams danielleadams added backport-blocked-v14.x backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. labels Aug 8, 2022
Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
@MoLow @Fyko
doc: mark --import as experimental
df47b0d 
PR-URL: nodejs#44067
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@RafaelGSS RafaelGSS mentioned this pull request Oct 14, 2022
Merged
@aduh95 aduh95 removed the backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. label Sep 6, 2023
@ruyadorno ruyadorno added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Sep 7, 2023
@ruyadorno
Copy link
Member

This commit depends on having #43942 land in v18 first in order to be backported. It's pb a better idea to just include this bit on the backport and mark this one as backport-blocked-v18.x I'll just leave both marked as backport-requested for now though.

aduh95 pushed a commit to aduh95/node that referenced this pull request Sep 7, 2023
@MoLow @aduh95
doc: mark --import as experimental
7a87cf0 
PR-URL: nodejs#44067
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
aduh95 pushed a commit to aduh95/node that referenced this pull request Sep 7, 2023
@MoLow @aduh95
doc: mark --import as experimental
d72d372 
PR-URL: nodejs#44067
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@aduh95 aduh95 mentioned this pull request Sep 7, 2023
Closed
ruyadorno pushed a commit that referenced this pull request Sep 8, 2023
@MoLow @ruyadorno
doc: mark --import as experimental
aaaa54d 
PR-URL: #44067
Backport-PR-URL: #49539
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@ruyadorno ruyadorno mentioned this pull request Sep 8, 2023
Merged
@ruyadorno ruyadorno added backported-to-v18.x PRs backported to the v18.x-staging branch. and removed backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. labels Sep 9, 2023
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@MoLow @ruyadorno
doc: mark --import as experimental
239b4ea 
PR-URL: #44067
Backport-PR-URL: #49539
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@targos targos targos approved these changes

@tniessen tniessen tniessen approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backported-to-v18.x PRs backported to the v18.x-staging branch. cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@MoLow @nodejs-github-bot @danielleadams @ruyadorno @benjamingr @targos @tniessen @aduh95