Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src,buffer: remove unused chars_written parameter #44092

Merged
merged 1 commit into from
Aug 4, 2022
Merged

src,buffer: remove unused chars_written parameter #44092

merged 1 commit into from
Aug 4, 2022

Commits on Aug 2, 2022

  1. src,buffer: remove unused chars_written parameter 

    This parameter was always being set to `nullptr` by its callers, either
explicitly or implicitly via the default argument. It was also buggy, as
in some cases it wouldn't be written to, potentially leaking stack
memory (see the early returns in `StringBytes::WriteUCS2`). Remove it
entirely.
    @kvakil
    kvakil committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    5ab85e7 View commit details
    Browse the repository at this point in the history