Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-api: generalize finalizer second pass callback #44141

Closed
wants to merge 2 commits into from
Closed

node-api: generalize finalizer second pass callback #44141

wants to merge 2 commits into from

Commits on Nov 18, 2022

  1. node-api: generalize finalizer second pass callback 

    Generalize the finalizer's second pass callback to make it
cancellable and simplify the code around the second pass callback.

With this change, it is determined that Reference::Finalize or
RefBase::Finalize are called once, either from the env's shutdown,
or from the env's second pass callback.

All existing node-api js tests should pass without a touch. The
js_native_api cctest is no longer applicable with this change,
just removing it.
    @legendecas
    legendecas committed Nov 18, 2022
    Copy the full SHA
    57a58d1 View commit details
    Browse the repository at this point in the history

  2. fixup! verify dangling napi_ref in napi_wrap

    @legendecas
    legendecas committed Nov 18, 2022
    Copy the full SHA
    344493a View commit details
    Browse the repository at this point in the history