Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: iterate over base objects to prepare for snapshot #44192

Merged
merged 2 commits into from Aug 12, 2022
Merged

src: iterate over base objects to prepare for snapshot #44192

merged 2 commits into from Aug 12, 2022

Commits on Aug 9, 2022

  1. src: iterate over base objects to prepare for snapshot 

    Instead of iterating over the bindings, iterate over the base
objects that are snapshottable. This allows us to snapshot
base objects that are not bindings. In addition this refactors
the InternalFieldInfo class to eliminate potential undefined
behaviors, and renames it to InternalFieldInfoBase.
The {de}serialize callbacks now expect a InternalFieldInfo struct
nested in Snapshotable classes that can be used to carry
serialization data around. This allows us to create structs
inheriting from InternalFieldInfo for Snapshotable objects
that need custom fields.
    @joyeecheung
    joyeecheung committed Aug 9, 2022
    Copy the full SHA
    931be85 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2022

  1. fixup! src: iterate over base objects to prepare for snapshot

    @joyeecheung
    joyeecheung committed Aug 10, 2022
    Copy the full SHA
    817385a View commit details
    Browse the repository at this point in the history